Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve searching of component browser entries #5645

Merged
merged 9 commits into from
Feb 16, 2023

Conversation

galin-enso
Copy link
Contributor

@galin-enso galin-enso commented Feb 13, 2023

Pull Request Description

Closes #5102

This PR improves searching entries in the component browser. Now the searcher input is also matched to the code that a component would generate, and the best match of the two is used for filtering and sorting the components in the component browser.

unknown_2023.02.13-18.23.mp4

Entry name formatting

Additionally, the component entry's displayed name format is changed to show the method's name first, followed by the type name in parentheses. This formatting fits better in the narrow columns of the component browser.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@galin-enso galin-enso marked this pull request as ready for review February 16, 2023 10:06
@MichaelMauderer
Copy link
Contributor

QA passed

@galin-enso galin-enso added the CI: Ready to merge This PR is eligible for automatic merge label Feb 16, 2023
@mergify mergify bot merged commit b771728 into develop Feb 16, 2023
@mergify mergify bot deleted the wip/galin-enso/improve-entries-searching-5102 branch February 16, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve entries searching
3 participants