Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix polyglot number comparison #5623

Closed
wants to merge 5 commits into from
Closed

Fix polyglot number comparison #5623

wants to merge 5 commits into from

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Feb 10, 2023 •
edited
Loading

Pull Request Description

Fix polyglot number comparison/equality.

Important Notes

Checklist

Please include the following checklist in your PR:

  • Wait until Comparators support partial ordering #5778 is merged
  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@Akirathan Akirathan linked an issue Feb 10, 2023 that may be closed by this pull request
Equality with polyglot numbers is broken #5177
Closed
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 10, 2023
@Akirathan Akirathan self-assigned this Feb 10, 2023
@Akirathan Akirathan mentioned this pull request Feb 10, 2023
Closed
1 task
@Akirathan Akirathan force-pushed the wip/akirathan/poly-num-eq-5177 branch from a729d85 to d062a7f Compare February 10, 2023 14:37
@Akirathan
Copy link
Member Author

Equals_Spec.enso is failing and #5744 should help with that. Waiting until #5744 is merged.

@Akirathan Akirathan force-pushed the wip/akirathan/poly-num-eq-5177 branch from d062a7f to c2c4779 Compare February 24, 2023 09:33
@Akirathan
Copy link
Member Author

Wait until #5778 is merged.

@Akirathan
Copy link
Member Author

Closing in favor of #5832.

@Akirathan Akirathan closed this Mar 7, 2023
@Akirathan Akirathan deleted the wip/akirathan/poly-num-eq-5177 branch March 11, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley will be requested when the pull request is marked ready for review jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd will be requested when the pull request is marked ready for review radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis will be requested when the pull request is marked ready for review GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley will be requested when the pull request is marked ready for review AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey will be requested when the pull request is marked ready for review marthasharkey is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 will be requested when the pull request is marked ready for review 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach will be requested when the pull request is marked ready for review JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp will be requested when the pull request is marked ready for review hubertp is a code owner

Assignees

@Akirathan Akirathan

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equality with polyglot numbers is broken
1 participant
@Akirathan