-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greying out pending nodes in the IDE #4088
Conversation
Here is a video showing the greying out behavior. The source code of the example is available in pivotal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From code point of view, all looks good. Visually I'm not sure if using the stripes here is right, as it calls for attention a lot. Maybe using a little less strong gray color would make it look better as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, however, can we have video attached to this PR showing thi in action and showing corner cases, to be sure this PR works as intended? :)
I had some problems uploading the video and embedding it, but here is a link to mp4 file - I am able to successfully play it on Chrome (but not on Firefox) or download it and play it with |
Thanks a lot Pawel for helping me navigate in the IDE codebase!
Anyone with more visual design skills than me (e.g. everyone), feel free to suggest changes or directly commit into this PR and improve colors & etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the video I see two big issues:
- The graph turns red when editing the node. It should not.
- When nodes are marked as not computed, the optional arguments are not displayed. We still know what these nodes refer to, so the arguments should be there.
That behavior not related to my changes. If you think that is a bug, it needs to be addressed separately. And yes, I find the "turning red" behavior strange as well. As discussed with Wojciech I've reported this problem in pivotal. |
I'd like to fix that, but that is way deeper in the IDE code than I can dig into easily. Btw. the video associated with #4006 shows the same issue - IDE doesn't render optional arguments when node is in pending/errorneous/non-normal state. |
At the end #4006 got integrated quickly and there is no need for this PR anymore. Thanks everyone who provided me guidance, reviews and pointed out visual flaws in my proposed implementation. |
Pull Request Description
Adding node
Kind::Pending
and associating it with some grey like color schemes.Important Notes
Some of us might have been hoping for a fix completely on the engine side, but it is already a month and the fix doesn't exist yet. It is not clear how much work is required to create such fix. Rather than hoping for it, I propose to use the
Pending
information which is already available in the IDE since #3729I don't claim to be a visual expert. I am ready to adapt the visual presentation according to suggestions of the IDE guys.
Checklist
Please include the following checklist in your PR:
Rust
style guides.
./run ide build
and./run ide watch
.