Dynamic dropdown support

CHANGELOG.md

@@ -86,6 +86,8 @@
   present only when the argument is of type that has a predefined set of values.
 - [Separate component browser navigator sections for modules imported from
   different namespaces][4044]
+- [Added contextual suggestions to argument dropdowns][4072]. Dropdowns will now
+  contain suggestions which are based on evaluated data.
 
 #### EnsoGL (rendering engine)
 
@@ -462,6 +464,7 @@
 [4063]: https://github.com/enso-org/enso/pull/4063
 [4078]: https://github.com/enso-org/enso/pull/4078
 [4097]: https://github.com/enso-org/enso/pull/4097
+[4072]: https://github.com/enso-org/enso/pull/4072
 
 #### Enso Compiler
 

app/gui/controller/double-representation/src/node.rs

@@ -24,7 +24,7 @@ use std::cmp::Ordering;
 
 
 
-/// Node Id is the Ast Id attached to the node's expression.
+/// Node Id is the AST ID attached to the node's expression.
 pub type Id = ast::Id;
 
 
@@ -224,7 +224,7 @@ impl NodeInfo {
         expression_id_matches() || doc_comment_id_matches()
     }
 
-    /// Get the ast id of the line with the node comment (if present).
+    /// Get the AST ID of the line with the node comment (if present).
     pub fn doc_comment_id(&self) -> Option<ast::Id> {
         self.documentation.as_ref().and_then(|comment| comment.ast().id())
     }
@@ -245,7 +245,7 @@ impl NodeInfo {
 /// Representation of the main line of the node (as opposed to a documentation line).
 ///
 /// Each node must have exactly one main line.
-/// Main line always contains an expression, either directly or under binding. The expression id
+/// Main line always contains an expression, either directly or under binding. The expression ID
 /// must be set and it serves as the whole node's expression.
 #[derive(Clone, Debug)]
 #[allow(missing_docs)]
@@ -419,7 +419,7 @@ impl MainLine {
         }
     }
 
-    /// Modify expression, preserving the AST id.
+    /// Modify expression, preserving the AST ID.
     fn modify_expression(&mut self, f: impl FnOnce(&mut Ast)) {
         let id = self.id();
         match self {
@@ -431,15 +431,15 @@ impl MainLine {
         self.set_id(id);
     }
 
-    /// Add [`SKIP`] macro call to the AST. Preserves the expression id and [`FREEZE`] macro calls.
+    /// Add [`SKIP`] macro call to the AST. Preserves the expression ID and [`FREEZE`] macro calls.
     fn add_skip_macro(&mut self) {
         self.modify_expression(|ast| {
             prepend_with_macro(ast, SKIP_MACRO_IDENTIFIER);
         });
         self.macros_info_mut().skip = true;
     }
 
-    /// Remove [`SKIP`] macro call from the AST. Preserves the expression id and [`FREEZE`] macro
+    /// Remove [`SKIP`] macro call from the AST. Preserves the expression ID and [`FREEZE`] macro
     /// calls.
     fn remove_skip_macro(&mut self) {
         self.modify_expression(|ast| {
@@ -448,15 +448,15 @@ impl MainLine {
         self.macros_info_mut().skip = false;
     }
 
-    /// Add [`FREEZE`] macro call to the AST. Preserves the expression id and [`SKIP`] macro calls.
+    /// Add [`FREEZE`] macro call to the AST. Preserves the expression ID and [`SKIP`] macro calls.
     fn add_freeze_macro(&mut self) {
         self.modify_expression(|ast| {
             *ast = preserving_skip(ast, |ast| prepend_with_macro(ast, FREEZE_MACRO_IDENTIFIER));
         });
         self.macros_info_mut().freeze = true;
     }
 
-    /// Remove [`FREEZE`] macro call from the AST. Preserves the expression id and [`SKIP`] macro
+    /// Remove [`FREEZE`] macro call from the AST. Preserves the expression ID and [`SKIP`] macro
     /// calls.
     fn remove_freeze_macro(&mut self) {
         self.modify_expression(|ast| {

app/gui/controller/engine-protocol/src/language_server/types.rs

@@ -1117,8 +1117,8 @@ impl<T> FieldUpdate<T> {
 }
 
 #[derive(Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)]
-#[serde(rename_all = "camelCase")]
 #[allow(missing_docs)]
+#[serde(tag = "type")]
 pub enum SuggestionArgumentUpdate {
     #[serde(rename_all = "camelCase")]
     Add { index: usize, argument: SuggestionEntryArgument },

app/gui/language/ast/impl/src/id_map.rs

@@ -36,8 +36,10 @@ impl IdMap {
         self.vec.push((span.into(), id));
     }
     /// Generate random Uuid for span.
-    pub fn generate(&mut self, span: impl Into<enso_text::Range<Byte>>) {
-        self.vec.push((span.into(), Uuid::new_v4()));
+    pub fn generate(&mut self, span: impl Into<enso_text::Range<Byte>>) -> Uuid {
+        let uuid = Uuid::new_v4();
+        self.vec.push((span.into(), uuid));
+        uuid
     }
 }
 

app/gui/language/ast/impl/src/known.rs

@@ -41,7 +41,7 @@ impl<T> KnownAst<T> {
         KnownAst { ast, phantom: default() }
     }
 
-    /// Gets AST id.
+    /// Gets AST ID.
     pub fn id(&self) -> Option<crate::Id> {
         self.ast.id
     }

app/gui/language/ast/impl/src/opr.rs

@@ -260,18 +260,18 @@ impl GeneralizedInfix {
     }
 
     /// The self operand, target of the application.
-    pub fn target_operand(&self) -> Operand {
+    pub fn target_operand(&self) -> &Operand {
         match self.assoc() {
-            Assoc::Left => self.left.clone(),
-            Assoc::Right => self.right.clone(),
+            Assoc::Left => &self.left,
+            Assoc::Right => &self.right,
         }
     }
 
     /// Operand other than self.
-    pub fn argument_operand(&self) -> Operand {
+    pub fn argument_operand(&self) -> &Operand {
         match self.assoc() {
-            Assoc::Left => self.right.clone(),
-            Assoc::Right => self.left.clone(),
+            Assoc::Left => &self.right,
+            Assoc::Right => &self.left,
         }
     }
 
@@ -283,11 +283,11 @@ impl GeneralizedInfix {
     }
 
     fn flatten_with_offset(&self, offset: usize) -> Chain {
-        let target = self.target_operand();
+        let target = self.target_operand().clone();
         let rest = ChainElement {
             offset,
             operator: self.opr.clone(),
-            operand: self.argument_operand(),
+            operand: self.argument_operand().clone(),
             infix_id: self.id,
         };
 

app/gui/language/span-tree/example/src/lib.rs

@@ -28,7 +28,7 @@ pub fn main() {
     let parens_cr = ast::crumbs::MatchCrumb::Segs { val, index: 0 };
     let _input_span_tree = builder::TreeBuilder::<()>::new(36)
         .add_child(0, 14, node::Kind::Chained, PrefixCrumb::Func)
-        .add_child(0, 9, node::Kind::Operation, PrefixCrumb::Func)
+        .add_child(0, 9, node::Kind::operation(), PrefixCrumb::Func)
         .set_ast_id(Uuid::new_v4())
         .done()
         .add_empty_child(10, InsertionPointType::BeforeTarget)
@@ -42,7 +42,7 @@ pub fn main() {
         .set_ast_id(Uuid::new_v4())
         .add_child(1, 19, node::Kind::argument(), parens_cr1)
         .set_ast_id(Uuid::new_v4())
-        .add_child(0, 12, node::Kind::Operation, PrefixCrumb::Func)
+        .add_child(0, 12, node::Kind::operation(), PrefixCrumb::Func)
         .set_ast_id(Uuid::new_v4())
         .done()
         .add_empty_child(13, InsertionPointType::BeforeTarget)
@@ -62,7 +62,7 @@ pub fn main() {
                 .crumbs(PrefixCrumb::Func)
                 .new_child(|t| {
                     t.size(9.bytes())
-                        .kind(node::Kind::Operation)
+                        .kind(node::Kind::operation())
                         .crumbs(PrefixCrumb::Func)
                         .new_ast_id()
                 })
@@ -86,7 +86,7 @@ pub fn main() {
                         .crumbs(parens_cr)
                         .new_child(|t| {
                             t.size(12.bytes())
-                                .kind(node::Kind::Operation)
+                                .kind(node::Kind::operation())
                                 .crumbs(PrefixCrumb::Func)
                                 .new_ast_id()
                         })

app/gui/language/span-tree/src/action.rs

@@ -118,7 +118,7 @@ impl<'a, T> Implementation for node::Ref<'a, T> {
                 use node::InsertionPointType::*;
                 let kind = &ins_point.kind;
                 let ast = root.get_traversing(&self.ast_crumbs)?;
-                let expect_arg = matches!(kind, ExpectedArgument(_));
+                let expect_arg = kind.is_expected_argument();
                 let extended_infix =
                     (!expect_arg).and_option_from(|| ast::opr::Chain::try_new(ast));
                 let new_ast = modify_preserving_id(ast, |ast| {
@@ -256,7 +256,7 @@ mod test {
             fn run(&self, parser: &Parser) {
                 let ast = parser.parse_line_ast(self.expr).unwrap();
                 let ast_id = ast.id;
-                let tree = ast.generate_tree(&context::Empty).unwrap(): SpanTree;
+                let tree: SpanTree = ast.generate_tree(&context::Empty).unwrap();
                 let node = tree.root_ref().find_by_span(&self.span.clone().into());
                 let node = node.unwrap_or_else(|| {
                     panic!("Invalid case {:?}: no node with span {:?}", self, self.span)
@@ -269,7 +269,7 @@ mod test {
                 .unwrap();
                 let result_repr = result.repr();
                 assert_eq!(result_repr, self.expected, "Wrong answer for case {self:?}");
-                assert_eq!(ast_id, result.id, "Changed AST id in case {self:?}");
+                assert_eq!(ast_id, result.id, "Changed AST ID in case {self:?}");
             }
         }
 
@@ -401,7 +401,7 @@ mod test {
         // Consider Span Tree for `foo bar` where `foo` is a method known to take 3 parameters.
         // We can try setting each of 3 arguments to `baz`.
         let tree = TreeBuilder::<()>::new(7)
-            .add_leaf(0, 3, node::Kind::Operation, PrefixCrumb::Func)
+            .add_leaf(0, 3, node::Kind::operation(), PrefixCrumb::Func)
             .add_leaf(4, 7, node::Kind::this(), PrefixCrumb::Arg)
             .add_empty_child(7, ExpectedArgument(1))
             .add_empty_child(7, ExpectedArgument(2))
@@ -427,7 +427,7 @@ mod test {
         // parameters. We can try setting each of 2 arguments to `baz`.
         let tree: SpanTree = TreeBuilder::new(10)
             .add_leaf(0, 4, node::Kind::this(), InfixCrumb::LeftOperand)
-            .add_leaf(5, 6, node::Kind::Operation, InfixCrumb::Operator)
+            .add_leaf(5, 6, node::Kind::operation(), InfixCrumb::Operator)
             .add_leaf(7, 10, node::Kind::argument(), InfixCrumb::RightOperand)
             .add_empty_child(10, ExpectedArgument(0))
             .add_empty_child(10, ExpectedArgument(1))