Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(183909391): Remove existing Cloud dashboard code #4047

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

indiv0
Copy link
Contributor

@indiv0 indiv0 commented Jan 12, 2023

Pull Request Description

Given that we have decided to go with a React-based approach for the combined IDE & Cloud UI, the cloud_dashboard written in EnsoGL is no longer applicable and is being removed. The bug fixes and refactors from that code that are still relevant have been separated into the following, smaller, PRs:

https://github.com/enso-org/cloud-v2/pull/116
https://github.com/enso-org/cloud-v2/pull/117
https://github.com/enso-org/cloud-v2/pull/118
https://github.com/enso-org/cloud-v2/pull/119

Meanwhile, the cloud_dashboard crate itself is being removed from the enso repo to ease future maintainability burdens.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it also remove all JS styles/things inserted to the codebase to make the Rust-based cloud dashboard working? I understand that the new implementation is on separate repo, so all CSS styles and JS changes introduced because of the Rust dashboard can be reverted now.

@indiv0
Copy link
Contributor Author

indiv0 commented Jan 18, 2023

Does it also remove all JS styles/things inserted to the codebase to make the Rust-based cloud dashboard working? I understand that the new implementation is on separate repo, so all CSS styles and JS changes introduced because of the Rust dashboard can be reverted now.

Unless I'm misunderstanding, we never added JS styles, only stylewatch styles, which were being added in the previously closed PR so they're not a concern.

@indiv0 indiv0 merged commit 4ea1880 into develop Jan 18, 2023
@indiv0 indiv0 deleted the wip/npekin/remove-cloud-dashboard-184219884 branch January 18, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants