Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric slider component enhancement #3885

Merged
merged 210 commits into from
Dec 12, 2022
Merged
Show file tree
Hide file tree
Changes from 209 commits
Commits
Show all changes
210 commits
Select commit Hold shift + click to select a range
a8b01ec
Simple structure upon which to build Slider (WIP)
galin-enso Nov 2, 2022
1c68a22
Baseline Slider (WIP)
galin-enso Nov 3, 2022
b5b4e7d
Added bounds and basic precision scaling
galin-enso Nov 4, 2022
21bb633
Cleaned up example scene
galin-enso Nov 4, 2022
8b94b6f
Implement set_width/height API
galin-enso Nov 7, 2022
6a76aef
Fix reset to 0 on click
galin-enso Nov 7, 2022
0f8c026
Center value text
galin-enso Nov 7, 2022
10a7f4d
Remove resize API
galin-enso Nov 7, 2022
1f26c78
Fix set_value update
galin-enso Nov 7, 2022
691d78d
Use precision for scaling instead of 1:1 movement
galin-enso Nov 7, 2022
8b74f39
Animate slider position
galin-enso Nov 7, 2022
ed3f3ee
Basic stepped precision adjustment
galin-enso Nov 7, 2022
bbb66b6
Snap value to precision steps
galin-enso Nov 8, 2022
f90eb07
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 8, 2022
c75eb81
Adjust slider display precision
galin-enso Nov 8, 2022
8f93611
Clean up layer management
galin-enso Nov 8, 2022
d327353
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 9, 2022
82c94a9
Clean up value printing
galin-enso Nov 9, 2022
ce8dc88
Use `shape!` macro
galin-enso Nov 9, 2022
fd7c2d2
Cleanup
galin-enso Nov 9, 2022
e53c8e2
Clamp value after precision snapping
galin-enso Nov 9, 2022
d48159e
Slider interaction only with primary mouse button
galin-enso Nov 9, 2022
da665a4
Value reset to default on cmd+click
galin-enso Nov 9, 2022
7614979
Clean up model functions
galin-enso Nov 9, 2022
d265120
Use Lcha color space
galin-enso Nov 9, 2022
ce2d928
Use bold text when slider value is not at default
galin-enso Nov 9, 2022
e1417d5
Make all element colors configurable
galin-enso Nov 9, 2022
577d7f4
Slider enable toggle
galin-enso Nov 9, 2022
49c518f
Configurable precision step margin and size
galin-enso Nov 9, 2022
670143f
Slider label with enable and inside toggles
galin-enso Nov 9, 2022
2e96f1e
Format
galin-enso Nov 10, 2022
df37e65
Fix disabled label
galin-enso Nov 10, 2022
346443d
Expand example
galin-enso Nov 10, 2022
5b5a252
Clean up value display truncation and splitting
galin-enso Nov 10, 2022
c89d5e9
Value alignment to decimal point
galin-enso Nov 10, 2022
d8720ec
Improve label visibility toggle
galin-enso Nov 10, 2022
a223f7c
Improve decimal point visibility toggle
galin-enso Nov 10, 2022
4063946
Update example
galin-enso Nov 10, 2022
d864592
Precision step exponentiation base as const
galin-enso Nov 10, 2022
7b63a74
Animate element colors
galin-enso Nov 10, 2022
439cc66
Clean up component resizing
galin-enso Nov 10, 2022
e559baf
Add comments/docs
galin-enso Nov 10, 2022
86c7518
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 10, 2022
ba447de
Fix lint
galin-enso Nov 10, 2022
a75e9b6
Margin around component shapes
galin-enso Nov 11, 2022
d0fd689
Restructure model.rs
galin-enso Nov 11, 2022
b460fa7
Formatting
galin-enso Nov 11, 2022
5193d9d
Clean up defaults
galin-enso Nov 11, 2022
5e224d9
Fix shape alignment
galin-enso Nov 11, 2022
646e13c
Move precision area defaults to separate function
galin-enso Nov 11, 2022
d988fb4
Clean up tuple use on value text splitting
galin-enso Nov 11, 2022
0c7ce3f
Move value text property set to separate function
galin-enso Nov 11, 2022
be2c490
Clean up Pixels conversion
galin-enso Nov 11, 2022
c08a457
Increase wasm-size-limit
galin-enso Nov 11, 2022
9419cc2
Lint
galin-enso Nov 11, 2022
2b7fac7
Add non-standard linter configuration
galin-enso Nov 11, 2022
0ac1c7d
Cleanup
galin-enso Nov 11, 2022
0ff2d90
Clean up element color logic
galin-enso Nov 14, 2022
ef21fc2
Cleanup
galin-enso Nov 14, 2022
e050e45
Clean up precision adjustment
galin-enso Nov 14, 2022
c901f5f
Clean up FRP style
galin-enso Nov 14, 2022
99c141b
Variable naming
galin-enso Nov 14, 2022
a97a474
Derive Deref
galin-enso Nov 14, 2022
1e25a8e
Clean up variable names
galin-enso Nov 14, 2022
4a59063
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 14, 2022
a8de05a
Clean up model docs
galin-enso Nov 14, 2022
de8a5ea
Update value text only on change
galin-enso Nov 14, 2022
52ca510
Update slider docs
galin-enso Nov 14, 2022
0265698
Format
galin-enso Nov 14, 2022
99569d0
Format
galin-enso Nov 14, 2022
933f1e6
Reaorder slider impl's
galin-enso Nov 14, 2022
2b73c22
Format
galin-enso Nov 14, 2022
442d229
Update mouse_y_local on click as well
galin-enso Nov 15, 2022
708b84a
Persist precision between slider adjustments
galin-enso Nov 15, 2022
63314ab
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 15, 2022
8fac815
Update precision and value on change only
galin-enso Nov 15, 2022
0941f1e
Limit length of value display
galin-enso Nov 15, 2022
1a92469
Unit tests for value formatting and splitting
galin-enso Nov 15, 2022
d76220e
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 15, 2022
d664538
Changelog entry
galin-enso Nov 15, 2022
b735926
Lint
galin-enso Nov 15, 2022
af28f47
Lint
galin-enso Nov 15, 2022
a5b94ce
Lint
galin-enso Nov 15, 2022
8359b75
Clean up mouse events
galin-enso Nov 16, 2022
afe46cd
Reorder sections
galin-enso Nov 16, 2022
7f9306c
Restructure FRP network definition
galin-enso Nov 16, 2022
cfb9104
Move decimal places limit to FRP
galin-enso Nov 16, 2022
ab715be
Format
galin-enso Nov 16, 2022
d0877eb
Revert persistent precision
galin-enso Nov 16, 2022
b058a86
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 16, 2022
36a57af
Fix test naming
galin-enso Nov 16, 2022
887f34a
Reduce recursion limit
galin-enso Nov 17, 2022
dad3ca1
Remove explicit to_im_string conversion
galin-enso Nov 17, 2022
4ef6da5
Clean up comments
galin-enso Nov 17, 2022
529f298
Clean up dependencies
galin-enso Nov 17, 2022
0799fae
Get slider colors from style
galin-enso Nov 17, 2022
4160c82
Set defaults for an operational slider
galin-enso Nov 17, 2022
ffdc54a
Remove recursion limit
galin-enso Nov 17, 2022
585fe47
Update cargo.lock
galin-enso Nov 17, 2022
c9e5df6
Merge branch 'develop' into wip/galin-enso/numeric-slider-update-1836…
galin-enso Nov 17, 2022
788dbdd
Show tooltip on precision change
galin-enso Nov 17, 2022
54482fe
Lint
galin-enso Nov 17, 2022
d817b70
Implement hard, soft, and adaptive slider limits
galin-enso Nov 18, 2022
caae374
Clean up adaptive limit functions
galin-enso Nov 18, 2022
447d9c5
Slider limit overflow markers
galin-enso Nov 18, 2022
b01cf99
Lint
galin-enso Nov 18, 2022
959a8b9
Add tooltip on component hover
galin-enso Nov 18, 2022
20c1f4b
Trim trailing zeroes in precision tooltip
galin-enso Nov 21, 2022
d2bc093
Restart tooltip timer after mouse is released
galin-enso Nov 21, 2022
07eeb25
Format
galin-enso Nov 21, 2022
ac69119
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 21, 2022
86ada96
Merge branch 'wip/galin-enso/numeric-slider-enhancement-183816694' of…
galin-enso Nov 21, 2022
568ba0d
Lint
galin-enso Nov 21, 2022
1218902
Break min/max value update cycle
galin-enso Nov 21, 2022
7ad54be
Textual editing of slider value
galin-enso Nov 21, 2022
7e85f7d
Proper formatting of value to edit
galin-enso Nov 22, 2022
c4574a4
Proper precision after editing value
galin-enso Nov 22, 2022
3cc1450
Revert edit if new string cannot be parsed
galin-enso Nov 22, 2022
fbe6ac6
Lint
galin-enso Nov 22, 2022
995e7a5
Format
galin-enso Nov 22, 2022
38c5245
Filter events when editing/dragging/disabled
galin-enso Nov 22, 2022
6c28a7b
Format
galin-enso Nov 22, 2022
2bc99ae
Make tooltip/popup timing adjustable through FRP
galin-enso Nov 22, 2022
30ef917
Disable tooltip when empty
galin-enso Nov 22, 2022
33c00b6
Enforce limits when editing value
galin-enso Nov 22, 2022
26c0945
Vertical slider input and track movement
galin-enso Nov 22, 2022
42e880e
Fix label location for vertical sliders
galin-enso Nov 22, 2022
6b9fd56
Example with vertical slider and different limits
galin-enso Nov 22, 2022
811f182
Format
galin-enso Nov 22, 2022
2f4e705
Move label position logic to model
galin-enso Nov 23, 2022
778255d
Fix vertical overflow marker position
galin-enso Nov 23, 2022
52047b9
Add vertical slider examples
galin-enso Nov 23, 2022
3ced023
Cleanup
galin-enso Nov 23, 2022
cd53030
Add orientation FRP output
galin-enso Nov 23, 2022
d4274ce
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 23, 2022
8909d7d
Fix missing output
galin-enso Nov 23, 2022
1b86713
Update changelog
galin-enso Nov 23, 2022
d99619e
Edit changelog entry
galin-enso Nov 23, 2022
d28aaf5
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 23, 2022
a1aec0f
Update Cargo.lock
galin-enso Nov 23, 2022
d7058a6
Update example layout
galin-enso Nov 23, 2022
7c70471
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 24, 2022
c02daf7
Limit precision after edit to default precision
galin-enso Nov 24, 2022
bb8e883
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 24, 2022
d7b0854
Reduce overflow marker size
galin-enso Nov 24, 2022
6b152dc
Rounded overflow marker corners
galin-enso Nov 24, 2022
66c1727
Added thumb mode
galin-enso Nov 25, 2022
a1b6576
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 25, 2022
6fd1db6
Fix for display object refactoring
galin-enso Nov 25, 2022
c812be9
Disable precision adjustment on scroll bar
galin-enso Nov 25, 2022
77c7a68
Set default font from theme
galin-enso Nov 25, 2022
29e067f
Disable text editing when value text is hidden
galin-enso Nov 25, 2022
7fcbbc1
Add various thumb sizes for scroll bars
galin-enso Nov 25, 2022
d5d7479
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 25, 2022
9cc21ff
Fix text editing
galin-enso Nov 28, 2022
b1eced9
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 28, 2022
aec128d
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 28, 2022
13dc4d8
Remove value trace
galin-enso Nov 28, 2022
e40a0e9
WIP remove sliders from example scene on shortcut
galin-enso Nov 28, 2022
09775d3
Drop example nodes with `D` and add with `A`
galin-enso Nov 29, 2022
a614826
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 29, 2022
71e2c94
Clean up
galin-enso Nov 30, 2022
c494a67
Merge branch 'wip/galin-enso/numeric-slider-enhancement-183816694' of…
galin-enso Nov 30, 2022
3045f00
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 30, 2022
6fecf1c
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 30, 2022
1afd62f
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Nov 30, 2022
dd8dec4
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 1, 2022
d9c2c75
Adjust threshold for limit shrinking
galin-enso Dec 2, 2022
a4d2966
Clean up documentation comments
galin-enso Dec 2, 2022
4dd963b
Change theme font to "default"
galin-enso Dec 2, 2022
5b32466
Clean up value editing switch
galin-enso Dec 2, 2022
9d1b615
Revert "Rounded overflow marker corners"
galin-enso Dec 2, 2022
1878273
Adjust overflow marker size
galin-enso Dec 2, 2022
77334c7
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 2, 2022
49c5e5a
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 2, 2022
01c98fc
Remove text defaults from theme
galin-enso Dec 2, 2022
5a06b6a
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 5, 2022
e19fd62
Fix example scene shortcuts
galin-enso Dec 6, 2022
bfd99f1
Change precision behavior
galin-enso Dec 6, 2022
cafa9ab
Merge branch 'wip/galin-enso/numeric-slider-enhancement-183816694' of…
galin-enso Dec 6, 2022
f9864d2
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 6, 2022
9226824
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 7, 2022
8568667
Move thumb exactly 1:1 with mouse too
galin-enso Dec 7, 2022
8c29cee
Center value text when displaying integers.
galin-enso Dec 7, 2022
e830911
Add example with integer value display
galin-enso Dec 7, 2022
b5401ac
Fix track glitches on large slider values
galin-enso Dec 7, 2022
750e0c5
Limit displayed decimal places on vertical sliders
galin-enso Dec 7, 2022
f62ed9d
Increase wasm-size-limit
galin-enso Dec 7, 2022
0519c6e
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 7, 2022
0642172
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 8, 2022
3968f26
Remove value animation, add limits animation
galin-enso Dec 8, 2022
4fa3f50
Cleanup
galin-enso Dec 8, 2022
beef694
Fix decimal display after text editing
galin-enso Dec 8, 2022
6abe516
Fix value indicator movement with extended limits
galin-enso Dec 8, 2022
310f613
Smooth value changes only on large steps
galin-enso Dec 8, 2022
ec0963f
Cleanup
galin-enso Dec 8, 2022
aef95ba
Animate value on reset and precision switch
galin-enso Dec 8, 2022
8e7372f
Fix adaprive limits, sample limits on drag start
galin-enso Dec 8, 2022
2d37bf0
Comment fix
galin-enso Dec 8, 2022
6cd07da
Fix edit lost on drag
galin-enso Dec 8, 2022
ef29de3
Recursively extend/shrink limits
galin-enso Dec 8, 2022
3de649c
Increase wasm-size-limit
galin-enso Dec 8, 2022
67e9cd3
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 8, 2022
ac2830c
Fix animated precision adjustment
galin-enso Dec 9, 2022
ae3ca38
Compute adaptive limit only if needed
galin-enso Dec 9, 2022
70f534b
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 9, 2022
78e3260
Do not drag slider on ctrl+click
galin-enso Dec 9, 2022
33d403c
Fix animated precision adjustment
galin-enso Dec 9, 2022
8f60424
Fix for lag in track/thumb motion
galin-enso Dec 9, 2022
8759350
Merge branch 'develop' into wip/galin-enso/numeric-slider-enhancement…
galin-enso Dec 12, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@
- [Added a new component: Slider][3852]. It allows adjusting a numeric value
with the mouse. The precision of these adjustments can be increased or
decreased.
- [Slider component functionality improvements][3885]. The slider component now
supports multiple ways to handle out-of-range values. The slider's value can
be edited as text, and a new vertical slider layout is available.
- [Added ProjectsGrid view for Cloud Dashboard][3857]. It provides the first
steps towards migrating the Cloud Dashboard from the existing React (web-only)
implementation towards a shared structure that can be used in both the Desktop
Expand Down Expand Up @@ -397,6 +400,7 @@
[3874]: https://github.com/enso-org/enso/pull/3874
[3852]: https://github.com/enso-org/enso/pull/3852
[3841]: https://github.com/enso-org/enso/pull/3841
[3885]: https://github.com/enso-org/enso/pull/3885
[3919]: https://github.com/enso-org/enso/pull/3919
[3923]: https://github.com/enso-org/enso/pull/3923

Expand Down
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Options intended to be common for all developers.

wasm-size-limit: 15.11 MiB
wasm-size-limit: 15.15 MiB

required-versions:
cargo-watch: ^8.1.1
Expand Down
1 change: 1 addition & 0 deletions lib/rust/ensogl/component/slider/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ edition = "2021"
[dependencies]
enso-frp = { path = "../../../frp" }
ensogl-core = { path = "../../core" }
ensogl-tooltip = { path = "../../component/tooltip/" }
ensogl-hardcoded-theme = { path = "../../app/theme/hardcoded" }
ensogl-text = { path = "../text" }
Loading