Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scroll overshoot bounce animation #3836

Merged
merged 19 commits into from
Nov 7, 2022

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Oct 31, 2022

Pull Request Description

Implements https://www.pivotaltracker.com/n/projects/2539304/stories/183390749

scroll-overshoot.mp4

Important Notes

  • The overshoot bounce animation is implemented as a animation-like FRP mixin. It is currently defined using define_endpoints macro, but should be migrated to define_endpoints_2 as soon as it supports "frp mixins" - definitions that extend external networks.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@Frizi Frizi marked this pull request as ready for review October 31, 2022 13:15
@Frizi Frizi requested a review from MichaelMauderer November 2, 2022 13:39
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Nov 3, 2022
@Frizi Frizi removed the CI: Ready to merge This PR is eligible for automatic merge label Nov 3, 2022
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Nov 7, 2022
@mergify mergify bot merged commit ed384bd into develop Nov 7, 2022
@mergify mergify bot deleted the wip/frizi/scroll-bounce-183390749 branch November 7, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants