Check methods of a type are present on its Atoms #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
force-pushed
the
wip/jtulach/CheckAtomMembers_183000876
branch
from
d107f90 to
1716ab6
Compare
kustosz
approved these changes
Sep 7, 2022
JaroslavTulach
added
the
CI: Ready to merge
4e6
approved these changes
Sep 7, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Found a bug when accessing keys via
get(constructor). Providing a test and a fix.Important Notes
Marcin, is it correct that the whole set of members of
Endis:[head, tail, Int, is_empty, IntList]? What doesIntandIntListdo there? Shall test test check for their presence? Answer: renameIntandIntListto lowercase and yes, then the members shall be there. Done in ca9f42a.Checklist
Please include the following checklist in your PR:
[ci no changelog needed]