-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Table.distinct
function to In-Memory table
#3684
Merged
mergify
merged 27 commits into
develop
from
wip/radeusgd/in-memory-table-distinct-182307143
Sep 7, 2022
Merged
Add Table.distinct
function to In-Memory table
#3684
mergify
merged 27 commits into
develop
from
wip/radeusgd/in-memory-table-distinct-182307143
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/in-memory-table-distinct-182307143
branch
from
September 5, 2022 09:03
b940cd9
to
c1cbbcf
Compare
Base automatically changed from
wip/radeusgd/in-memory-make-aggregator-storage-more-specific
to
develop
September 5, 2022 09:17
…ncy from std-table.
radeusgd
force-pushed
the
wip/radeusgd/in-memory-table-distinct-182307143
branch
from
September 5, 2022 10:27
7e1d237
to
2576115
Compare
jdunkerley
requested changes
Sep 5, 2022
std-bits/table/src/main/java/org/enso/table/aggregations/First.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/aggregations/Last.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/index/MultiValueIndex.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/index/MultiValueKeyBase.java
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/index/OrderedMultiValueKey.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/text/TextFoldingStrategy.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/index/UnorderedMultiValueKey.java
Show resolved
Hide resolved
jdunkerley
approved these changes
Sep 6, 2022
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Case.enso
Outdated
Show resolved
Hide resolved
Co-authored-by: James Dunkerley <[email protected]>
radeusgd
commented
Sep 6, 2022
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Case.enso
Outdated
Show resolved
Hide resolved
4e6
approved these changes
Sep 6, 2022
mergify
bot
deleted the
wip/radeusgd/in-memory-table-distinct-182307143
branch
September 7, 2022 12:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/182307143
Important Notes
std-table
module depends onstd-base
, as a provided dependency. This is allowed, becausestd-table
is used by theStandard.Table
Enso module which depends onStandard.Base
which ensures that thestd-base
is loaded onto the classpath, thus wheneverstd-table
is loaded byStandard.Table
, so isstd-base
. Thus we can rely on classes fromstd-base
and its dependencies being provided on the classpath. Thanks to that we can use utilities likeText_Utils
also instd-table
, avoiding code duplication. Additional advantage of that is that we don't need to specify ICU4J as a separate dependency forstd-table
, since it is 'taken' fromstd-base
already - so we avoid including it in our build packages twice.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.