Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Table.distinct function to In-Memory table #3684

Merged
merged 27 commits into from
Sep 7, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Sep 5, 2022

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182307143

Important Notes

  • Modified standard library Java helpers dependencies so that std-table module depends on std-base, as a provided dependency. This is allowed, because std-table is used by the Standard.Table Enso module which depends on Standard.Base which ensures that the std-base is loaded onto the classpath, thus whenever std-table is loaded by Standard.Table, so is std-base. Thus we can rely on classes from std-base and its dependencies being provided on the classpath. Thanks to that we can use utilities like Text_Utils also in std-table, avoiding code duplication. Additional advantage of that is that we don't need to specify ICU4J as a separate dependency for std-table, since it is 'taken' from std-base already - so we avoid including it in our build packages twice.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@radeusgd radeusgd self-assigned this Sep 5, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/in-memory-table-distinct-182307143 branch from b940cd9 to c1cbbcf Compare September 5, 2022 09:03
Base automatically changed from wip/radeusgd/in-memory-make-aggregator-storage-more-specific to develop September 5, 2022 09:17
@radeusgd radeusgd force-pushed the wip/radeusgd/in-memory-table-distinct-182307143 branch from 7e1d237 to 2576115 Compare September 5, 2022 10:27
@radeusgd radeusgd marked this pull request as ready for review September 5, 2022 10:34
@radeusgd radeusgd requested a review from jdunkerley September 5, 2022 22:55
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Sep 6, 2022
@mergify mergify bot merged commit 551100a into develop Sep 7, 2022
@mergify mergify bot deleted the wip/radeusgd/in-memory-table-distinct-182307143 branch September 7, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants