Get rid of free-floating atoms. Everything has a type now! #3671

kustosz · 2022-08-26T21:49:33Z

Pull Request Description

This is a step towards the new language spec. The type keyword now means something. So we now have

type Maybe a
    Some (from_some : a)
    None

as a thing one may write. Also Some and None are not standalone types now – only Maybe is.
This halfway to static methods – we still allow for things like Number + Number for backwards compatibility. It will disappear in the next PR.

The concept of a type is now used for method dispatch – with great impact on interpreter code density.

Some APIs in the STDLIB may require re-thinking. I take this is going to be up to the libraries team – some choices are not as good with a semantically different language. I've strived to update stdlib with minimal changes – to make sure it still works as it did.

It is worth mentioning the conflicting constructor name convention I've used: if Foo only has one constructor, previously named Foo, we now have:

type Foo
    Foo_Data f1 f2 f3

This is now necessary, because we still don't have proper statics. When they arrive, this can be changed (quite easily, with SED) to use them, and figure out the actual convention then.

I have also reworked large parts of the builtins system, because it did not work at all with the new concepts.

It also exposes the type variants in SuggestionBuilder, that was the original tiny PR this was based on.

PS I'm so sorry for the size of this. No idea how this could have been smaller. It's a breaking language change after all.

Important Notes

Checklist

Please include the following checklist in your PR:

The documentation has been updated if necessary.
All code conforms to the
Scala,
Java,
and
Rust
style guides.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed: Enso GUI was tested when built using BOTH
  ./run ide build and ./run ide watch.

engine/runtime/src/main/java/org/enso/interpreter/runtime/library/types/TypesLibrary.java

engine/runtime/src/main/scala/org/enso/compiler/PackageRepository.scala

engine/runtime/src/main/scala/org/enso/compiler/codegen/IrToTruffle.scala

engine/runtime/src/main/scala/org/enso/compiler/pass/analyse/BindingAnalysis.scala

radeusgd

I don't think I know the interpreter codebase to analyse the details very thoroughly without spending about a week on learning it deeper, so I'm approving based on other's approval and the fact that it works. It may be wise for @hubertp to review this PR post-mortem, as I think he knows these parts much better.

As for what I saw - it seems to look good.

I'm sooooo glad of the unified method dispatch in one place instead of being scattered in various type definitions. This is AWESOME!

Apart from that I have a few minor comments or questions. What I think would be good to sort out before merging is removing leftover commented-out code (I marked a few, I'm not entirely sure if there's more) - unless it should be kept - but then some comment explaining why would that be needed.

I've found at least one FIXME - I think it should be associated with some Pivotal task - then the link can be added to the comment.

engine/runtime/src/main/java/org/enso/interpreter/runtime/builtin/BuiltinType.java

Co-authored-by: James Dunkerley <[email protected]>

radeusgd · 2022-08-31T07:53:42Z

test/Table_Tests/src/Data_Formatter_Spec.enso

 type Custom_Type_With_Error
-    Custom_Type_With_Error_Data

    to_text : Text
    to_text self = Error.throw (Illegal_State_Error_Data "foo_error")


I'm not sure if I understand what happened here? You removed the ctor and pass the Type in the tests, so that you want to rely on the static variant of to_text for formatting? I guess that can work, but shouldn't then to_text not have the self parameter anymore?

probably being overzelaous, can be reverted

hubertp · 2022-09-12T09:30:05Z

engine/runtime/src/test/scala/org/enso/compiler/test/pass/desugar/OperatorToFunctionTest.scala

-
-      OperatorToFunction.runModule(moduleInput, modCtx) shouldEqual moduleOutput
-    }
+//    "be translated in module contexts" in {


@kustosz this can go, right?

hubertp · 2022-09-12T09:30:29Z

...e/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/DocumentationCommentsTest.scala

@@ -73,7 +73,7 @@ class DocumentationCommentsTest extends CompilerTest with Inside {
    */
  def getDoc(ir: IR): String = {
    val meta = ir.getMetadata(DocumentationComments)
-    meta shouldBe defined
+//    meta.shouldBe(defined)


@kustosz intentional?

Fixes #5805 by returning `[]` as list of fields of `Type`. # Important Notes `Type` is recognized as `Meta.is_atom` since #3671. However `Type` isn't an `Atom` internally. We have to provide special handling for it where needed.

kustosz added 30 commits June 28, 2022 15:09

better parsing of type sigs

fe10db6

testing facilities

084cdab

resolution testing

2d99f1a

plug in basic resolution

1b3457b

resolution of imported atoms

aeb2b28

make types exportable

8745762

use sigs in suggestion builder

683cd04

fix union types

2997cdc

fix the suggestion builder to use sum types

a0cdbe3

write proper level tests for unions

dde6c8c

fix all tests

6a83655

fix docs & tests

37ca55d

fix formatting

d4e7650

fmt & doc

1237536

keep moving towards actual tycons

e7bbb26

mega awesome fix

675fb78

checkpoint

abe1a4a

checkpoint

5a6d749

checkpoint

e3bbaaa

builtin dsl changes

9310fc7

keep fighting the compiler

2ce6fd2

holy cow it compiled

ff0f6a0

actually have some tests pass!

29f0bd0

fix dataflow analysis

7c54ab8

testing progress

64fbd07

another undeniable success

c7a81ee

more painstaking fixing

6d95c4a

keep going, try not to cry

f19c994

more progress

63b61f4

keep em passing

0d23124

radeusgd reviewed Aug 30, 2022

View reviewed changes

radeusgd approved these changes Aug 30, 2022

View reviewed changes

engine/runtime/src/main/java/org/enso/interpreter/runtime/builtin/BuiltinType.java Outdated Show resolved Hide resolved

kustosz and others added 19 commits August 30, 2022 20:49

some CR feedback;

034b74f

Update distribution/lib/Standard/Image/0.0.0-dev/src/Codecs.enso

06dc4e0

Co-authored-by: James Dunkerley <[email protected]>

Update distribution/lib/Standard/Image/0.0.0-dev/src/Codecs.enso

a52c828

Co-authored-by: James Dunkerley <[email protected]>

Update test/Table_Tests/src/Data_Formatter_Spec.enso

48c8bd9

Co-authored-by: James Dunkerley <[email protected]>

Update test/Table_Tests/src/Data_Formatter_Spec.enso

8ecf7a1

Co-authored-by: James Dunkerley <[email protected]>

Update test/Table_Tests/src/Data_Formatter_Spec.enso

4d9958a

Co-authored-by: James Dunkerley <[email protected]>

Update test/Table_Tests/src/Excel_Spec.enso

ec17e7f

Co-authored-by: James Dunkerley <[email protected]>

Update test/Tests/src/Semantic/Names_Spec.enso

9cfe2b0

Co-authored-by: James Dunkerley <[email protected]>

stuff

9a84217

.

65e2582

Update distribution/lib/Standard/Image/0.0.0-dev/src/Codecs.enso

fdf06a9

Co-authored-by: James Dunkerley <[email protected]>

Update distribution/lib/Standard/Image/0.0.0-dev/src/Codecs.enso

c91dc45

Co-authored-by: James Dunkerley <[email protected]>

Update test/Table_Tests/src/Excel_Spec.enso

83060ef

Co-authored-by: James Dunkerley <[email protected]>

Update test/Tests/src/Data/Text_Spec.enso

3ebf4a8

Co-authored-by: James Dunkerley <[email protected]>

continue

1bf52b8

fmt

8ff4f9e

fix tests

f733104

fmt

c73fea5

missing foc

2ee29c0

kustosz added the CI: Ready to merge This PR is eligible for automatic merge label Aug 30, 2022

mergify bot merged commit 4fc6dcc into develop Aug 30, 2022

mergify bot deleted the wip/mk/parse-types branch August 30, 2022 22:54

radeusgd reviewed Aug 31, 2022

View reviewed changes

hubertp reviewed Sep 12, 2022

View reviewed changes

JaroslavTulach mentioned this pull request Mar 9, 2023

Meta.get_constructor_fields works for Type #5869

Merged

2 tasks

JaroslavTulach mentioned this pull request May 9, 2023

Verify ascribed types of parameters really exist #6584

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get rid of free-floating atoms. Everything has a type now! #3671

Get rid of free-floating atoms. Everything has a type now! #3671

kustosz commented Aug 26, 2022

radeusgd left a comment

radeusgd Aug 31, 2022

kustosz Sep 1, 2022

hubertp Sep 12, 2022

hubertp Sep 12, 2022

Get rid of free-floating atoms. Everything has a type now! #3671

Get rid of free-floating atoms. Everything has a type now! #3671

Conversation

kustosz commented Aug 26, 2022

Pull Request Description

Important Notes

Checklist

radeusgd left a comment

Choose a reason for hiding this comment

radeusgd Aug 31, 2022

Choose a reason for hiding this comment

kustosz Sep 1, 2022

Choose a reason for hiding this comment

hubertp Sep 12, 2022

Choose a reason for hiding this comment

hubertp Sep 12, 2022

Choose a reason for hiding this comment