Implement value formatting and writing new files in Delimited format. #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/delimited-write-new-182309573
branch
8 times, most recently
from
6b8d386 to
e59c554
Compare
radeusgd
force-pushed
the
wip/radeusgd/delimited-write-new-182309573
branch
from
ce11d77 to
1a30069
Compare
jdunkerley
requested changes
Jun 23, 2022
std-bits/table/src/main/java/org/enso/table/write/DelimitedWriter.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/write/DelimitedWriter.java
Outdated
Show resolved
Hide resolved
jdunkerley
requested changes
Jun 23, 2022
std-bits/table/src/main/java/org/enso/table/formatting/IntegerFormatter.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/formatting/IntegerFormatter.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public boolean canFormat(Object value) { | ||
| return value instanceof Double || value instanceof Long; |
There was a problem hiding this comment.
Good question.
Currently I think this may not be strictly needed, because our Decimal-type column will contain all doubles and a mixed type column will delegate to the AnyObjectFormatter which will in turn delegate to IntegerFormatter for Longs. But theoretically if we had a mixed-storage column containing Longs and Doubles, and such a column had the DecimalFormatter selected - this functionality could be of use.
However, since currently it's not actively used it may be unnecessary to maintain it this way indeed. I can remove it.
jdunkerley
approved these changes
Jun 23, 2022
TODO: fix null handling
radeusgd
force-pushed
the
wip/radeusgd/delimited-write-new-182309573
branch
from
b1534f9 to
2d4537f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/182309429 and https://www.pivotaltracker.com/story/show/182309573
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.