Removing old functions and tidy up of Table types #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
force-pushed
the
wip/jd/table-tidy-182195335
branch
from
7e5d948 to
8f1d0a0
Compare
jdunkerley
force-pushed
the
wip/jd/table-tidy-182195335
branch
from
56e359b to
9be4abd
Compare
hubertp
approved these changes
Jun 13, 2022
radeusgd
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Looks good to me.
Just as Hubert mentioned, would be good to ping @mwu-tow regarding adding Examples test suite to the new CI and you should probably add it to the Legacy test suite (since it is the only test suite that is being run for macOS currently) - see scala.yml @ 284.
jdunkerley
removed
the
CI: Ready to merge
4e6
approved these changes
Jun 13, 2022
kazcw
pushed a commit
that referenced
this pull request
Jun 29, 2022
- Removed `select` method. - Removed `group` method. - Removed `Aggregate_Table` type. - Removed `Order_Rule` type. - Removed `sort` method from Table. - Expanded comments on `order_by`. - Update comment on `aggregate` on Database. - Update Visualisation to use new APIs. - Updated Data Science examples to use new APIs. - Moved Examples test out of Tests to own test. # Important Notes Need to get Examples_Tests added to CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
selectmethod.groupmethod.Aggregate_Tabletype.Order_Ruletype.sortmethod from Table.order_by.aggregateon Database.Important Notes
Need to get Examples_Tests added to CI.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.