Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic changes to File_Format #3516

Merged
merged 8 commits into from
Jun 8, 2022
Merged

Basic changes to File_Format #3516

merged 8 commits into from
Jun 8, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jun 7, 2022

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182308987

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide dist and ./run ide watch.
      …t type

@radeusgd radeusgd requested review from 4e6 and jdunkerley as code owners June 7, 2022 16:39
@radeusgd radeusgd self-assigned this Jun 7, 2022
jdunkerley
jdunkerley approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should have a change log.

hubertp
hubertp approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test for comparing Locales

@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jun 8, 2022
@mergify mergify bot merged commit 2af970f into develop Jun 8, 2022
@mergify mergify bot deleted the wip/radeusgd/update-file-format-182308987 branch June 8, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@hubertp hubertp hubertp approved these changes

@4e6 4e6 Awaiting requested review from 4e6

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radeusgd @hubertp @jdunkerley @JaroslavTulach