Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delimited File Encoding #3430

Merged
merged 26 commits into from
May 10, 2022
Merged

Delimited File Encoding #3430

merged 26 commits into from
May 10, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented May 4, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181998375

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@radeusgd radeusgd force-pushed the wip/radeusgd/file-delimited-encoding-181998375 branch 2 times, most recently from c5ac70f to c0cda51 Compare May 7, 2022 21:13
@radeusgd radeusgd self-assigned this May 9, 2022
@radeusgd radeusgd marked this pull request as ready for review May 9, 2022 10:38
@radeusgd radeusgd requested review from 4e6 and jdunkerley as code owners May 9, 2022 10:38
@radeusgd radeusgd force-pushed the wip/radeusgd/file-delimited-encoding-181998375 branch from 4c226ab to 3966748 Compare May 9, 2022 14:01
jdunkerley
jdunkerley requested changes May 9, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good - nothing major just a few little things

test/Table_Tests/data/windows.csv Show resolved Hide resolved
test/Table_Tests/src/Delimited_Read_Spec.enso Outdated Show resolved Hide resolved
std-bits/base/src/main/java/org/enso/base/Encoding_Utils.java Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Delimited_Reader.enso Outdated Show resolved Hide resolved
std-bits/base/src/main/java/org/enso/base/encoding/ReportingStreamDecoder.java Outdated Show resolved Hide resolved
std-bits/base/src/main/java/org/enso/base/encoding/ReportingStreamDecoder.java Show resolved Hide resolved
std-bits/base/src/main/java/org/enso/base/encoding/ReportingStreamDecoder.java Outdated Show resolved Hide resolved
std-bits/base/src/main/java/org/enso/base/encoding/ReportingStreamDecoder.java Outdated Show resolved Hide resolved
std-bits/base/src/main/java/org/enso/base/encoding/ReportingStreamDecoder.java Show resolved Hide resolved
@radeusgd radeusgd requested a review from jdunkerley May 9, 2022 16:45
@radeusgd radeusgd force-pushed the wip/radeusgd/file-delimited-encoding-181998375 branch from 2b1475e to 9f93c74 Compare May 10, 2022 08:57
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label May 10, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/file-delimited-encoding-181998375 branch from 117f2cc to 9580830 Compare May 10, 2022 15:11
@radeusgd radeusgd force-pushed the wip/radeusgd/file-delimited-encoding-181998375 branch from e375979 to 5570820 Compare May 10, 2022 21:56
@mergify mergify bot merged commit 64f178f into develop May 10, 2022
@mergify mergify bot deleted the wip/radeusgd/file-delimited-encoding-181998375 branch May 10, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @jdunkerley