Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Text.repeat and adding Text.* #3310

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Updating Text.repeat and adding Text.* #3310

merged 5 commits into from
Mar 2, 2022

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Mar 1, 2022 •
edited
Loading

Pull Request Description

Updating the Text.repeat function:

  • fix issue with negative count
  • add * operator

Add tests of the function.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@jdunkerley jdunkerley requested review from 4e6 and radeusgd as code owners March 1, 2022 17:48
radeusgd
radeusgd approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but IMO the negative values fix uncovers a deeper issue and we need to address it (in this PR or in a separate one).

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso Outdated Show resolved Hide resolved
@jdunkerley jdunkerley force-pushed the wip/jd/text-repeat-181264852 branch from 3874472 to e46f7a5 Compare March 2, 2022 17:40
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 2, 2022
@mergify mergify bot merged commit ad11305 into develop Mar 2, 2022
@mergify mergify bot deleted the wip/jd/text-repeat-181264852 branch March 2, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@4e6 4e6 Awaiting requested review from 4e6

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdunkerley @radeusgd