Add Snowflake to native-image #12193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach and
Akirathan
as code owners
This change adds Snowflake's jdbc library packaged in a fat jar. It's not a straightword inclusion mostly due to the complicated way how the jar itself is constructed: - it's a fat jar so includes other dependencies which we sometimes include - they are patching some of the dependencies and putting them under their subpackage making it impossible to use the `snowflake-jdbc-thin` dependency - a number of configs are spurious and need to be disabled - `FileTypeDetector` provider leads to runtime-/build-time initialization confict that is impossible to workaround without disabling it - need to open `java.base` module, similarly to #9664, due to Arrow's usage - `java.nio.DirectByteBuffer` constructor changed its signature in JDK21 from `(long, int)` to `(long, long)` which caused problems for the constructed NI and needed to be reflected in the config
hubertp
force-pushed
the
wip/hubert/12151-ni-snowflake
branch
from
f2b73b0 to
cb6fa59
Compare
JaroslavTulach
approved these changes
Jan 30, 2025
jdunkerley
approved these changes
Jan 30, 2025
Akirathan
approved these changes
Jan 31, 2025
| @@ -714,6 +714,12 @@ pub async fn runner_sanity_test( | |||
| .run_ok() | |||
| .await; | |||
|
|
|||
| let test_snowflake = Command::new(&enso) | |||
There was a problem hiding this comment.
- this should be improved as part of CI should run Standard Library Tests in both JVM and Native modes #12123
- at least that's what @4e6 claims
jdunkerley
added
the
CI: Keep up to date
jdunkerley
removed
the
CI: Keep up to date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This change adds Snowflake's jdbc library packaged in a fat jar.
Closes #12151.
Important Notes
It's not a straightforward inclusion mostly due to the complicated way how the jar itself is constructed:
snowflake-jdbc-thindependencyFileTypeDetectorprovider leads to runtime-/build-time initialization conflict that is impossible to workaround without disabling itjava.basemodule, similarly to Open Java modules for Snowflake setup #9664, due to Arrow's usagejava.nio.DirectByteBufferconstructor changed its signature in JDK21 from(long, int)to(long, long)which caused problems for the constructed NI and needed to be reflected in the configChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.