Quick Fix Import Button

[JaroslavTulach]

Pull Request Description

Based on the ideas presented in the #12019 discussion this PR introduces a quick fix button capable of automatically adding the missing import statement when a fully qualified name is used without a library being imported.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  TypeScript,
• Manually tested
• Unit tests skipped for now

[github-actions]

🧪 Storybook is successfully deployed!

📊 Dashboard:

• 👀 Review changes: https://www.chromatic.com/build?appId=673738989fc3e8430364197e&number=1096
• 👨‍🎨 Preview storybook: https://673738989fc3e8430364197e-xqvycikeet.chromatic.com/

[JaroslavTulach]

Let's start with following source code:

from Standard.Base import all

main =
    file1 = Standard.Table.Row.Row
    file2 = Row
    node1 = Standard.Microsoft.Main

by default all three nodes yield an error:

The Row node shows the regular error message as present these days, because the message isn't recognized as something that could be fixed.

However there is another Standard.Table.Row.Row node and it offers a quick fix button (instead of the copy message). Let's click it:

The source code gets a new import Standard.Table and the Standard.Table.Row.Row node immediately resolves to a node without error. The same can be repeated with the Standard.Microsoft.Main node. After clicking its Fix Import button, the node gets fixed. The final source code looks like this:

from Standard.Base import all
import Standard.Table
import Standard.Microsoft

main =
    file1 = Standard.Table.Row.Row
    file2 = Row
    node1 = Standard.Microsoft.Main

[Akirathan]

Isn't this message somewhere as constant? Seems a bit dangerous to hardcode it like this.

[JaroslavTulach]

It may be a constant, but in Java code. We don't have a way to share constants between Java and JavaScript. However you are right. This is slightly fragile, in the long run we could try:

[JaroslavTulach]

Let's enhance the language server protocol we have. For example let's extend Diagnostic with possible hints, like:

hint: {
  type: "import",
  add: "Standard.Table"
}

that way we would formalize this API - would be better in the long run then depending on the text of the message.

[JaroslavTulach]

The fix import button continues to "fix import" even when latest develop branch was merged in.

• I think have addressed review comments
• I haven't written any unit test - I am not sure what to copy...

Can I merge? Before today's demo?

[farmaazon]

For unit testing, the code needs to be a bit refactored... But I think they're not needed, as this is easy party and will be overhauled at some point (to not use hard-coded message, for example).

But before merging, see my comment

[JaroslavTulach]

Green enough. Let's get this in and claim a cooperation success.