Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing helper methods in
Standard.Base.Meta
#12031Reducing helper methods in
Standard.Base.Meta
#12031Changes from all commits
d2ce49c
a18693e
531ecdf
4ae769b
9770c1a
17fdff4
0c074ac
4ef7d8b
fd5d2af
ab9287f
b4f4483
2eef96b
530f3af
b4116c8
30e5005
d426ab3
7aacc66
3516a2d
47f8e34
11eafee
5331e49
5ff29d1
8c6ddd6
110d9d4
6eab870
5716344
dc5d820
2f78b17
33bdcbd
67fcec2
2f8d126
e776053
4daed89
a394c4e
57d19a7
ba13b0d
90d2e2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instrumentor
is a nice concept, but probably not something we want to expose from a public API. It is still fine to have it and test it, but makingprivate
and moving theInstrumentor_Spec
intotest/Base_Internal_Tests
.Y.js+Insight (as being worked on by @4e6) should be the future of instrumentation and it doesn't need the
Meta_Helpers.instrumentor_builtin
as it is using GraalVM Insight directly.