Cleanup jline dependencies #12020
Merged
Cleanup jline dependencies #12020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A wild attempt at fixing MacOS signing process that prevents nightlies from working. Also cleaned up dependencies for wrapper projects - `scala-compiler` was unnecessary and was introducing jline requirement.
hubertp
requested review from
4e6,
JaroslavTulach,
Akirathan,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
hubertp
added
CI: No changelog needed
JaroslavTulach
approved these changes
Jan 8, 2025
| "org.scala-lang" % "scala-reflect" % scalacVersion, | ||
| "org.scala-lang" % "scala-compiler" % scalacVersion | ||
| val scalaReflect = Seq( | ||
| "org.scala-lang" % "scala-reflect" % scalacVersion |
There was a problem hiding this comment.
Removing scala-compiler from our dependencies seems beneficial on its own.
| @@ -1,7 +1,6 @@ | |||
| module org.enso.scala.wrapper { | |||
| requires scala.library; | |||
| requires scala.reflect; | |||
| requires org.jline; | |||
hubertp
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
jdunkerley
approved these changes
Jan 8, 2025
somebody1234
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A wild attempt at fixing MacOS signing process that prevents nightlies from working.
Also cleaned up dependencies for wrapper projects -
scala-compilerwas unnecessary and was introducing jline requirement.Related to #11957.
Important Notes
Not sure if this will fix the nightly as I'm still unable to confirm the real issue but this doesn't hurt.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.