Expand parent directories of opened projects

[somebody1234]

Pull Request Description

• https://github.com/enso-org/cloud-v2/issues/1499
  • Expand parent directories of opened projects when switching to directories

Important Notes

None

Testing Instructions

• Open a project on each backend (cloud and local) and test that it works for both
• Open a project and make sure it's expanded on a different category (team category and root, user category and root, add subdirectory of enso/ to local favorites and open project)

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• Unit tests have been written where possible.
• If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
  or the Snowflake database integration, a run of the Extra Tests has been scheduled.
  • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

[github-actions]

🧪 Storybook is successfully deployed!

📊 Dashboard:

• 👀 Review changes: https://www.chromatic.com/build?appId=673738989fc3e8430364197e&number=850
• 👨‍🎨 Preview storybook: https://673738989fc3e8430364197e-ujzbtxipzu.chromatic.com/

[somebody1234]

@MrFlashAccount not too sure about this one. should i be putting things in a ref like elsewhere, to make sure it doesn't unintentionally open all parent directories out of nowhere?

(is this not the right approach at all?)

[MrFlashAccount]

I don't get why it's an useEffect

[somebody1234]

true, what's the alternative though? i think we need to re-expand the directories every time the category changes, right?

[somebody1234]

we can avoid resetting expandedDirectories every time the category changes and only run this one. but i think it'd still need to be a useEffect, right? i don't think it should be hardcoded to be permanently expanded because otherwise you wouldn't collapse directories (e.g. if the directory has a lot of children so you want to collapse it)

[somebody1234]

actually, i don't know if this is an option right now as currently we depend on expandedDirectoryIds to control which listDirectory queries are being fetched

[MrFlashAccount]

yup. that was my original concern, but i don't see a way to avoid it fully. in the react compiler optimization PR i just moved dependencies that aren't real dependencies to a syncref but if you have a better idea i'm definitely down to change it

We have useEventCallback for that, here's a good explanation on why it's needed: https://github.com/reactjs/rfcs/blob/useevent/text/0000-useevent.md

[MrFlashAccount]

sounds good, but i'm worried about discoverability. i think it'd be cool for the icons to change into buttons to trigger dropdown menus on hover, but i dunno whether that's a good idea

Yeah, good idea

Though, we need to add ActionMenu component first: https://react-spectrum.adobe.com/react-spectrum/ActionMenu.html#actionmenu

[somebody1234]

rfe: useEventCallback... thoughts? do you mean to reference non-deps in the eventCallback directly and then use a useEffect that passes the reactive deps into the function?

[MrFlashAccount]

One thing on implementation: ideally this should support multitabs

[MrFlashAccount]

thoughts? do you mean to reference non-deps in the eventCallback directly and then use a useEffect that passes the reactive deps into the function?

Yeah, like that. Deps that shouldn't trigger effect, should be incapsulated inside the useEventCallback function