Fix bugs around mass selection/single selection/drag and drop #11942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able # Conflicts: # app/gui/src/dashboard/components/dashboard/AssetRow.tsx
MrFlashAccount
added
CI: No changelog needed
🧪 Storybook is successfully deployed!📊 Dashboard:
|
MrFlashAccount
commented
Dec 26, 2024
MrFlashAccount
requested review from
PabloBuchu,
indiv0,
somebody1234,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
PabloBuchu
approved these changes
Dec 27, 2024
|
@MrFlashAccount this one i would like a video preview of |
MrFlashAccount
added
the
CI: Keep up to date
MrFlashAccount
added
CI: Ready to merge
mergify
bot
deleted the
wip/sergeigarin/fix-selection-in-assets-table
branch
Frizi
pushed a commit
that referenced
this pull request
Dec 30, 2024
Closes: enso-org/cloud-v2#1633 This PR: 1. Refactors the Selection Brush component - improve visuals, improved performance, added support for scrolling containers 2. Now dragging can only be started over a selected row. 3. If a row is not selected, Brush selection is applied 4. This PR isolates the root view from Portals, this guaranties that portals will always be over the root view 5. Adds new utilities and hooks. 6. Fixes floating bug when selection doesn't happen on click 7. Changes the behavior of unselection: from blacklist (everything except a few elements) to whitelist (if user clicks on Special component - unselect). Special component can be placed anywhere we want. clicks on other elements are ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes: https://github.com/enso-org/cloud-v2/issues/1633
This PR:
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.