Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive bugs #11925

Merged
merged 34 commits into from
Dec 30, 2024
Merged

Drive bugs #11925

merged 34 commits into from
Dec 30, 2024

Conversation

MrFlashAccount
Copy link
Contributor

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1493

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Dec 19, 2024
@MrFlashAccount MrFlashAccount self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/drive-bugs branch from 7e3f0fe to c7af0cb Compare December 22, 2024 10:41
@MrFlashAccount MrFlashAccount changed the title [skip ci] Drive bugs Drive bugs [skip ci] Dec 22, 2024
@MrFlashAccount MrFlashAccount changed the title Drive bugs [skip ci] Drive bugs Dec 22, 2024
@MrFlashAccount MrFlashAccount marked this pull request as ready for review December 23, 2024 16:59
somebody1234
somebody1234 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label Dec 30, 2024
@MrFlashAccount
Merge branch 'develop' into wip/sergeigarin/drive-bugs
96ef9fd 
# Conflicts:
#	app/gui/src/dashboard/components/AriaComponents/Tooltip/Tooltip.tsx
#	app/gui/src/dashboard/components/dashboard/AssetRow.tsx
#	app/gui/src/dashboard/layouts/AssetsTable.tsx
#	app/gui/src/dashboard/layouts/TabBar.tsx
@MrFlashAccount
Fix types
95f6bbe
@mergify mergify bot merged commit 51bdbde into develop Dec 30, 2024
40 of 41 checks passed
@mergify mergify bot deleted the wip/sergeigarin/drive-bugs branch December 30, 2024 13:56
Frizi pushed a commit that referenced this pull request Dec 30, 2024
@MrFlashAccount @Frizi
Drive bugs (#11925)
b282e57 
Closes: enso-org/cloud-v2#1493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somebody1234 somebody1234 somebody1234 approved these changes

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees

@MrFlashAccount MrFlashAccount

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrFlashAccount @PabloBuchu @somebody1234