Small fixes from loading doc site. #11921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
requested review from
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
marthasharkey
approved these changes
Dec 19, 2024
AdRiley
approved these changes
Dec 19, 2024
jdunkerley
added
CI: No changelog needed
GregoryTravis
approved these changes
Dec 19, 2024
radeusgd
reviewed
Dec 19, 2024
Comment on lines
+192
to
196
| ? Name Filter Rules | ||
|
|
||
| The `name_filter` can contain the following special characters: | ||
| - `"?"` - which matches a single filename character (so it will not match a | ||
| `"/"`). |
There was a problem hiding this comment.
Shouldn't the text following ? Name Filter Rules heading be indented 2 spaces? I think that was the format we used to align to.
jdunkerley
added a commit
that referenced
this pull request
Dec 19, 2024
Fixes from loading docs. (cherry picked from commit 0f88ffd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes from loading docs.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.