Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with inline stings. #11907

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix issue with inline stings. #11907

merged 1 commit into from
Dec 18, 2024

Conversation

jdunkerley
Copy link
Member

Pull Request Description

Inline strings in Excel files were not processed correctly.
Now fixed and test added.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 18, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Dec 18, 2024
@mergify mergify bot merged commit bfa52b7 into develop Dec 18, 2024
38 of 40 checks passed
@mergify mergify bot deleted the wip/jd/excel-inline-strings branch December 18, 2024 15:48
jdunkerley added a commit that referenced this pull request Dec 18, 2024
@jdunkerley
Fix issue with inline stings. (#11907)
38f2582 
Inline strings in Excel files were not processed correctly.
Now fixed and test added.

(cherry picked from commit bfa52b7)
somebody1234 pushed a commit that referenced this pull request Dec 24, 2024
@jdunkerley @somebody1234
Fix issue with inline stings. (#11907)
6ecd687 
Inline strings in Excel files were not processed correctly.
Now fixed and test added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@radeusgd radeusgd radeusgd approved these changes

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdunkerley @radeusgd @GregoryTravis