-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symetric, transitive and reflexive equality for intersection types #11897
Conversation
There is a failure in test/Base_Tests line enso/test/Base_Tests/src/Semantic/Conversion_Spec.enso Lines 321 to 324 in e4a4bcc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice tests. Let's not forget to write benchmarks for intersection types before we start using them in std libs.
() -> { | ||
var bothValue = ctx.asValue(both); | ||
var asIntegerTo = conv.execute(0, bothValue); | ||
var asIntegerCast = conv.execute(1, bothValue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you forgot to test style 2 and 3, i.e.:
var asTextTo = conv.execute(2, bothValue);
var asTextCast = conv.execute(3, bothValue);
assertTrue(equals.execute(asTextTo, asTextCast).asBoolean());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, not only it is not called, but it is also broken. These two new tests added in d30da41 are failing on CI
- tests ignored in 02080f9 and reported
multi_value.to
doesn't work on second & further elements of intersection type #11935
Pull Request Description
Fixes #11845 by comparing all the types an
EnsoMultiValue
has been cast to.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,