Clean up integration tests and add listeners for backend calls #11847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
somebody1234
force-pushed
the
wip/sb/more-integration-tests
branch
from
d6030af to
c796cde
Compare
somebody1234
requested review from
indiv0,
PabloBuchu and
MrFlashAccount
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
|
|
||
| setup('authenticate', ({ page }) => { | ||
| const authFilePath = actions.getAuthFilePath() | ||
| setup.slow() |
There was a problem hiding this comment.
btw, why we need to setup.slow() here?
MrFlashAccount
approved these changes
Dec 12, 2024
| @@ -1,35 +1,39 @@ | |||
| /** @file Test the login flow. */ | |||
| import { expect, test, type Page } from '@playwright/test' | |||
| // import { expect, test, type Page } from '@playwright/test' | |||
There was a problem hiding this comment.
Can we use test.skip here?
| @@ -1,31 +1,34 @@ | |||
| /** @file Test the "change password" modal. */ | |||
| import { expect, test, type Page } from '@playwright/test' | |||
| // import { expect, test, type Page } from '@playwright/test' | |||
somebody1234
added
the
CI: Ready to merge
jdunkerley
pushed a commit
that referenced
this pull request
Dec 13, 2024
- Close enso-org/cloud-v2#1604 - Add ability to track backend calls - Remove inconsistent integration test code - Add skeleton classes for settings pages # Important Notes None (cherry picked from commit b83c5a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Testing Instructions
N/A - there are no changes to the codebase outside of tests
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.