-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmarks upload GH Action #11842
Conversation
|
``` | ||
|
||
## Relation to GH Actions | ||
The `bench_download.py` script is used in [Benchmarks Upload](https://github.com/enso-org/enso/actions/workflows/bench-upload.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not for now, but I'm wondering we could at some point move this script into Enso :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know the script well enough to be able to tell much, but on the surface the changes seem ok.
Fixes the Benchmarks Upload action that is failing since 2024-12-09. Also adds automatic generation of enso-org/engine-benchmark-results:cache/index.json file.
Pull Request Description
Modifies the Benchmarks Upload job to also upload special
cache/index.json
file that maps filenames in the cache to their timestamps.This is necessary for #10212 but it is also good for an Enso workflow that analyses benchmarks from the locally cloned repo. (The workflow will soon be pushed to the https://github.com/enso-org/engine-benchmark-results repo)
Important Notes
Moreover, the
Benchmarks Upload
job fails since yesterday (https://github.com/enso-org/enso/actions/runs/12269442294/job/34233007971), because there is an old workflow ID used for the engine benchmarks.To allow more convenient testing of the Action, I have added an ability to trigger this action manually in 857c086
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
or the Snowflake database integration, a run of the Extra Tests has been scheduled.