Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks upload GH Action #11842

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Dec 11, 2024

Fixes the Benchmarks Upload action that is failing since 2024-12-09. Also adds automatic generation of enso-org/engine-benchmark-results:cache/index.json file.

Pull Request Description

Modifies the Benchmarks Upload job to also upload special cache/index.json file that maps filenames in the cache to their timestamps.

This is necessary for #10212 but it is also good for an Enso workflow that analyses benchmarks from the locally cloned repo. (The workflow will soon be pushed to the https://github.com/enso-org/engine-benchmark-results repo)

Important Notes

Moreover, the Benchmarks Upload job fails since yesterday (https://github.com/enso-org/enso/actions/runs/12269442294/job/34233007971), because there is an old workflow ID used for the engine benchmarks.

To allow more convenient testing of the Action, I have added an ability to trigger this action manually in 857c086

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan self-assigned this Dec 11, 2024
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 11, 2024
@Akirathan
Copy link
Member Author

@Akirathan Akirathan changed the title Wip/akirathan/bench index json Fix benchmarks upload GH Action Dec 11, 2024
```

## Relation to GH Actions
The `bench_download.py` script is used in [Benchmarks Upload](https://github.com/enso-org/enso/actions/workflows/bench-upload.yml)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not for now, but I'm wondering we could at some point move this script into Enso :)

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the script well enough to be able to tell much, but on the surface the changes seem ok.

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Dec 12, 2024
@mergify mergify bot merged commit 4d88dd1 into develop Dec 12, 2024
35 of 38 checks passed
@mergify mergify bot deleted the wip/akirathan/bench-index-json branch December 12, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants