Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight missing required arguments #11803

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Highlight missing required arguments #11803

merged 5 commits into from
Dec 9, 2024
+34 −10

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Dec 6, 2024 •
edited
Loading

Pull Request Description

Highlight names of absent required arguments.

Captura de ecrã 2024-12-06, às 09 10 11

(UI demo; implementation only applies the effect to same arguments that cause a "Provide a value" error)

Fixes #11631.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw kazcw self-assigned this Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@kazcw kazcw marked this pull request as ready for review December 6, 2024 17:08
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Dec 9, 2024
@mergify mergify bot merged commit a666ef0 into develop Dec 9, 2024
50 checks passed
@mergify mergify bot deleted the wip/kw/highlight-missing-args branch December 9, 2024 14:19
jdunkerley pushed a commit that referenced this pull request Dec 10, 2024
@kazcw @jdunkerley
Highlight missing required arguments (#11803)
98938ce 
Highlight names of absent required arguments.

<img width="947" alt="Captura de ecrã 2024-12-06, às 09 10 11" src="https://github.com/user-attachments/assets/aaf8afcc-3998-4685-9e99-81a123f920b7">

(UI demo; implementation only applies the effect to same arguments that cause a "Provide a value" error)

Fixes #11631.

(cherry picked from commit a666ef0)
jdunkerley pushed a commit that referenced this pull request Dec 10, 2024
@kazcw @jdunkerley
Highlight missing required arguments (#11803)
83397de 
Highlight names of absent required arguments.

<img width="947" alt="Captura de ecrã 2024-12-06, às 09 10 11" src="https://github.com/user-attachments/assets/aaf8afcc-3998-4685-9e99-81a123f920b7">

(UI demo; implementation only applies the effect to same arguments that cause a "Provide a value" error)

Fixes #11631.

(cherry picked from commit a666ef0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees

@kazcw kazcw

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph Editor Look&Feel - Red highlight on parameters with missing value.
2 participants
@kazcw @farmaazon