Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second iteration of Dashboard Fixes #11781

Merged
merged 26 commits into from
Dec 9, 2024

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Dec 5, 2024

Pull Request Description

Fixes:

  • Opening deleted folder
  • Icons
  • Diff view collapsed
  • Password input for passwords in settings
  • Save button appears only if form in settings is dirty
  • Disable clear trash button if it's empty
  • Disable D&D in the root folder
  • Disable Create actions if user select a folder without sufficient permissions
  • Many more

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount changed the title Wip/sergeigarin/dashboard-fixes-1592-2 Second iteration of Dashboard Fixes Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount self-assigned this Dec 6, 2024
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Dec 6, 2024
@MrFlashAccount MrFlashAccount marked this pull request as ready for review December 6, 2024 20:03
@PabloBuchu
Copy link
Contributor

  1. No gear icon next to Local
  2. | Discover didn’t open for a new user. Should show if no projects in the home folder.
    still not working
  3. | In root folder, creating projects should be disabled. Currently get an odd error message.
    We can't create assets thats great can we also disabled context menu completely on Users / Teams directories? label, copy, copy as path, description are resulting in 500. Right side panel also doesnt make any sense

@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Dec 9, 2024
@MrFlashAccount
Copy link
Contributor Author

No gear icon next to Local

Fixed ✅

Discover didn’t open for a new user. Should show if no projects in the home folder.
still not working.

Should be working now, but worth noting that the registration happens in the browser, and the browser opens the outdated gui

@mergify mergify bot merged commit 3ad09a1 into develop Dec 9, 2024
43 of 49 checks passed
@mergify mergify bot deleted the wip/sergeigarin/dashboard-fixes-1592-2 branch December 9, 2024 20:43
jdunkerley pushed a commit that referenced this pull request Dec 10, 2024
Fixes:

- Opening deleted folder
- Icons
- Diff view collapsed
- Password input for passwords in settings
- Save button appears only if form in settings is dirty
- Disable clear trash button if it's empty
- Disable D&D in the root folder
- Disable Create actions if user select a folder without sufficient permissions
- Many more

(cherry picked from commit 3ad09a1)
jdunkerley pushed a commit that referenced this pull request Dec 10, 2024
Fixes:

- Opening deleted folder
- Icons
- Diff view collapsed
- Password input for passwords in settings
- Save button appears only if form in settings is dirty
- Disable clear trash button if it's empty
- Disable D&D in the root folder
- Disable Create actions if user select a folder without sufficient permissions
- Many more

(cherry picked from commit 3ad09a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants