Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New alias analysis API #11621

Merged
merged 2 commits into from
Nov 21, 2024
Merged

New alias analysis API #11621

merged 2 commits into from
Nov 21, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Nov 21, 2024

Pull Request Description

Higher level API will be compatible with a future implementation that doesn't depend on RawAst (see: #10753).

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw
New alias analysis API
d8bcd54 
Higher level API will be compatible with a future implementation that doesn't
depend on `RawAst` (see: #10753).
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 21, 2024
@kazcw kazcw self-assigned this Nov 21, 2024
@kazcw kazcw marked this pull request as ready for review November 21, 2024 22:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited by unfurl-links bot
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

Frizi
Frizi approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Frizi Frizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🚀

@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Nov 21, 2024
@mergify mergify bot merged commit d611939 into develop Nov 21, 2024
52 of 53 checks passed
@mergify mergify bot deleted the wip/kw/alias-analysis-api branch November 21, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frizi Frizi Frizi approved these changes

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees

@kazcw kazcw

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazcw @Frizi