Add widget for name_filter
#11455
Merged
Add widget for name_filter
#11455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
radeusgd
requested review from
jdunkerley,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
|
|
jdunkerley
approved these changes
Oct 30, 2024
GregoryTravis
approved these changes
Oct 30, 2024
| Builds a widget intended to be used for `name_filter` of `File.list` and | ||
| its siblings that allows to filter file names by file format. | ||
| name_filter_widget -> Widget = | ||
| known_patterns = File_Format.all.flat_map .get_name_patterns |
There was a problem hiding this comment.
Does File_Format.all still include Auto_Detect?
There was a problem hiding this comment.
Yes:
all = [Auto_Detect] + format_types
There was a problem hiding this comment.
Ok, I had missed that you added get_name_patterns to that.
There was a problem hiding this comment.
Yep, I thought that since Auto_Detect will accept any file from the known formats, we could define its set of patterns as a union of known formats' patterns. This also comes in handy because we wanted the "All known formats" entry in the dropdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Data.listname filter fromFile_Format.name_patterns#11310Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.