Move TypeSignature into field of Function #11364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
kazcw
force-pushed
the
wip/kw/function-signature-field
branch
from
93a0952 to
734f286
Compare
kazcw
requested review from
4e6,
JaroslavTulach,
hubertp,
Akirathan,
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
JaroslavTulach
approved these changes
Oct 20, 2024
Akirathan
approved these changes
Oct 21, 2024
vitvakatu
approved these changes
Oct 22, 2024
lib/rust/parser/src/syntax/tree.rs
Outdated
| pub name: Tree<'s>, | ||
| /// The `:` token. | ||
| pub operator: token::TypeAnnotationOperator<'s>, | ||
| /// The variable's type. |
There was a problem hiding this comment.
nit: are functions considered variables?
lib/rust/parser/src/syntax/tree.rs
Outdated
| @@ -268,13 +270,7 @@ macro_rules! with_ast_definition { ($f:ident ($($args:tt)*)) => { $f! { $($args) | |||
| }, | |||
| /// Statement declaring the type of a variable. | |||
There was a problem hiding this comment.
nit: another case when we call a function variable
lib/rust/parser/src/syntax/tree.rs
Outdated
| /// The variable's type. | ||
| #[reflect(rename = "type")] | ||
| pub type_: Tree<'s>, | ||
| pub signature: FunctionTypeSignature<'s>, |
There was a problem hiding this comment.
nit: I’m not sure why it is called FunctionTypeSignature. Shouldn’t it be TypeSignature, as it can be used with variables as well?
lib/rust/parser/src/syntax/tree.rs
Outdated
| @@ -874,6 +906,8 @@ impl From<SyntaxError> for Cow<'static, str> { | |||
| PatternUnexpectedDot => "In a pattern, the dot operator can only be used in a qualified name", | |||
| CaseOfInvalidCase => "Invalid case expression.", | |||
| DocumentationUnexpectedNonInitial => "Unexpected documentation at end of line", | |||
| UnexpectedTypeSignatureDeclaration => | |||
There was a problem hiding this comment.
This kind of error is not emitted anywhere; is it useful?
kazcw
force-pushed
the
wip/kw/function-signature-field
branch
from
ca8afe5 to
65a5934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Move type-signature lines into
Functionfield. Also implements #11293.Stacked on #11346.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.