Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel build system #11337

Open
wants to merge 144 commits into
base: develop
Choose a base branch
from
Open

Bazel build system #11337

wants to merge 144 commits into from
+18,648 −1,653

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Oct 16, 2024

Pull Request Description

Created a bazel-based build system, implemented a whole GUI build target within it.

Currently this PR open in order to develop and test the github actions workflow.

Frizi and others added 30 commits April 19, 2024 14:39
@Frizi
initial bazel config wip
bdce72d
@hubertp
.bazelignore and .bazelversion
6836fa8
@hubertp
bump rules_nodejs to fix node version issue
d9387ac
@Frizi
bazel gui2 start of vite build
f0fe74e
@Frizi
Merge branch 'wip/frizi/bazel' of github.com:enso-org/enso into wip/f…
314af22 
…rizi/bazel
@hubertp
Initial build setup for backend
873b904
@hubertp
nit
e8a67cc
@Frizi
declare missing pnpm transitive deps
b3f9472
@Frizi
Merge branch 'wip/frizi/bazel' of github.com:enso-org/enso into wip/f…
51d55d2 
…rizi/bazel
@hubertp
compile with graalvm
ab61bd0
@hubertp
common options
cd8f504
@hubertp
Mixed Scala/Java, fixed scala_rules for latest JDK
fede7ef 
Using latest JDK (after proper GraalVM integration) broke compilation of
Scala projects due to a problem with SecurityManager in `scala_rules`.
Workaround it by having custom toolchain.

Added example BUILD for mixed Scala/Java project with a small number of
dependencies.
@hubertp
update module lock
94e3a35
@hubertp
test
0ae2b60
@hubertp
ignore directories
5bb8e4b
@hubertp
tests setup
38604ca
@hubertp
generate pom.xml via bazel-distribution
2d52296
@Frizi
Merge branch 'develop' into wip/frizi/bazel
01b8f4e
@Frizi
rust progress
4467c27
@Frizi
Merge branch 'develop' into wip/frizi/bazel
03df7f0
@Frizi
Merge branch 'develop' into wip/frizi/bazel
45bab8b
@Frizi
progress on rust compilation
2ef150e
@Frizi
Merge branch 'develop' into wip/frizi/bazel
fd6824c
@Frizi
rust-ffi compiles through cargo again
259fb02
@Frizi
Merge branch 'develop' into wip/frizi/bazel
c9aba8d
@Frizi
Merge branch 'develop' into wip/frizi/bazel
272d416
@Frizi
Merge branch 'develop' into wip/frizi/bazel
4b6eebe
@Frizi
update bazelignore
1c2b068
@Frizi
rust-ffi wasm is building
fc4dba1
@Frizi
Merge remote-tracking branch 'origin/develop' into wip/frizi/bazel
6c69b33
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@vitvakatu vitvakatu changed the title [WIP] Bazel build system Bazel build system Dec 20, 2024
@4e6
Copy link
Contributor

4e6 commented Dec 20, 2024 •
edited by unfurl-links bot
Loading

Please run the nightly workflow on this branch to make sure that it does not break the release https://github.com/enso-org/enso/actions/workflows/nightly.yml

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Nightly Release · Workflow runs · enso-org/enso

@4e6
Copy link
Contributor

4e6 commented Dec 20, 2024 •
edited
Loading

Otherwise, I'm ok with the change even though it edits the generated workflow files. I can update the workflow generation logic after the merge to unblock the progress on the Bazel build.

hubertp
hubertp approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please address the minor comments.
Pretty sure this is going to break something but we can address it on a per-need basis.

app/common/src/index.ts

/** Company name, used as the copyright holder. */
export const COMPANY_NAME: string
export const COMPANY_NAME: string = 'New Byte Order sp. z o.o.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's correct. It should be

Suggested change
export const COMPANY_NAME: string = 'New Byte Order sp. z o.o.'
export const COMPANY_NAME: string = 'Enso International, Inc.'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. This PR doesn't actually change that value. I just combined index.js/index.d.ts into a single index.ts file. You can see previous assignment here:

enso/app/common/src/index.js

Line 22 in e5a1c5a

export const COMPANY_NAME = 'New Byte Order sp. z o.o.'

app/gui/.env
@@ -0,0 +1,23 @@
# CAUTION: this file is intentionally NOT ignored. If you want to override those variables, create an `.env.local` file.
ENSO_IDE_AG_GRID_LICENSE_KEY=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's gonna break a lot of local dev setups and should definitely be documented/announced appropriately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this is to be a safe fallback that you don't have to worry about.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will provide a temlate .env.local file on Discord when the PR lands.

@vitvakatu
Copy link
Contributor

I'm ok with the change even though it edits the generated workflow files.

@4e6 Oh, it is not supposed to do that. Running cargo run --package enso-build-ci-gen does no changes to the workflow files. Can you point me at these edits?

@4e6
Copy link
Contributor

4e6 commented Dec 20, 2024

Running cargo run --package enso-build-ci-gen does no changes

Sorry, I did not notice the changes in ci_gen.rs because the run script was moved under the build tools

@radeusgd
Copy link
Member

Does this change anything about our daily dev workflow or are the changes only relevant to CI?

@Frizi
Copy link
Contributor Author

Frizi commented Dec 20, 2024

Does this change anything about our daily dev workflow or are the changes only relevant to CI?

The changes are made specifically to not require any local setup changes yet. Things that are already fully ported to bazel right now run automatically. Everything else stays the same for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitvakatu vitvakatu vitvakatu approved these changes

@somebody1234 somebody1234 somebody1234 approved these changes

@radeusgd radeusgd radeusgd approved these changes

@hubertp hubertp hubertp approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@MrFlashAccount MrFlashAccount Awaiting requested review from MrFlashAccount MrFlashAccount is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees
No one assigned
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Frizi @somebody1234 @4e6 @vitvakatu @radeusgd @hubertp