Use IR.STRUCTURE_COMPARATOR to compare two IR objects
#11178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
changed the title
IR.STRUCTURE_COMPARATOR to compare two IR objects
JaroslavTulach
added
the
CI: Clean build required
JaroslavTulach
added
the
CI: Keep up to date
JaroslavTulach
removed
the
CI: Keep up to date
|
Got the failure in parallel PR CI run. Need review! |
hubertp
approved these changes
Sep 30, 2024
| return 0; | ||
| } | ||
| var aCopy = aIr.duplicate(true, false, false, true); | ||
| var bCopy = bIr.duplicate(true, false, false, true); |
There was a problem hiding this comment.
That looks expensive if we do it for every IR that we read?
There was a problem hiding this comment.
We are not doing this for every IR we read. The code is only performed before exception:
sb.append("Adding at ").append(at).append(" object:\n ");
dumpObject(sb, res);
sb.append("\nbut there already is:\n ");
dumpObject(sb, prev);
sb.append("\nare they equal: ").append(bothObjectsAreTheSame);is logged or thrown. How frequently that happens? It happens on CI from time to time. I haven't seen it on my computer yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10985 by providing a special
IR.STRUCTURE_COMPARATORthat removes metadata and diagnostics before comparing twoIRobjects. Inefficient, not fully correct, but enough for the debugging purposes thisprev != nullcheck was introduced.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,