Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update mode to Table.Running #11045

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Sep 11, 2024

Pull Request Description

Table.Running needed an update mode to allow overwriting existing columns

Important Notes

Would appreciate second opinions on

group_builder.specify "Not setting the name updates the first column if update_mode update"

That is the one behaviour I am uncertain about

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley added this to the 2024-08 Release milestone Sep 11, 2024
@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 11, 2024
@AdRiley AdRiley merged commit a666585 into develop Sep 11, 2024
36 of 37 checks passed
@AdRiley AdRiley deleted the wip/adr/fix-running-update-existing-column branch September 11, 2024 14:41
jdunkerley pushed a commit that referenced this pull request Sep 11, 2024
(cherry picked from commit a666585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants