Log details when to_display_text invocation fails
#11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
hubertp
approved these changes
Sep 10, 2024
JaroslavTulach
commented
Sep 10, 2024
| @@ -153,6 +158,7 @@ static Object handleExceptionMessage( | |||
| try { | |||
| return Text.create(strings.asString(text)); | |||
| } catch (UnsupportedMessageException e) { | |||
| ctx.getLogger().log(Level.WARNING, "Cannot convert " + text + " to string", e); | |||
There was a problem hiding this comment.
@hubertp, is this the right way to dump additional info into CI log including:
- a message
- value of
text - exception
ewith its stacktrace
If not, can you please update the line to dump such an info so it appears in the CI log when the error happens?
|
Should help addressing #10750 |
JaroslavTulach
changed the title
to_display_text invocation fails
JaroslavTulach
added
the
CI: Ready to merge
JaroslavTulach
requested review from
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
JaroslavTulach
force-pushed
the
wip/jtulach/Log10770
branch
from
70634d2 to
8b284c2
Compare
GregoryTravis
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #10770 by dumping out more information when
to_display_textinvocations fails.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,