-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix component list scrolling #10937
Fix component list scrolling #10937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this bugfix, the old code here seems to me actually correct. All it does is to select a range of elements to render baesd on scroller viewport, and I don't see any flaw in that logic.
The issue seems to be that the scrolling.scrollPosition
can actually lie - the reported "scroll position" is past the scroll height bounds. So my propsed fix would be to instead limit that value, something like this:
const scrolling = useScrolling(() =>
Math.min(animatedHighlightPosition.value, listContentHeight.value - scrollerSize.value.y),
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't mean to approve 🫨
Indeed, the proposed fix is easier and works perfectly fine. |
Ilya Bogdanov reports a new STANDUP for the provided date (2024-08-30): Progress: Debugged and fixed component list scrolling. It should be finished by 2024-08-30. |
Pull Request Description
Fixes #10927
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.