Add vectorized rounding operation to Decimal columns #10912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
requested review from
jdunkerley,
radeusgd,
AdRiley and
marthasharkey
as code owners
AdRiley
approved these changes
Aug 29, 2024
radeusgd
reviewed
Aug 29, 2024
| import org.enso.table.error.UnexpectedTypeException; | ||
| import org.graalvm.polyglot.Context; | ||
|
|
||
| /** An operation rounding floating-point numbers. */ |
There was a problem hiding this comment.
This comment seems to be misaligned with the class.
radeusgd
reviewed
Aug 29, 2024
| for (int i = 0; i < storage.size(); i++) { | ||
| if (!storage.isNothing(i)) { | ||
| BigDecimal value = storage.getItem(i); | ||
| BigDecimal result = Decimal_Utils.round(value, (int) decimalPlaces.longValue(), useBankers); |
There was a problem hiding this comment.
I know that decimalPlaces will not overflow int because check_decimal_places ensures it is between [-15; 15]. Still I think it would be safer to include an assert here to ensure that the overflow does not happen.
radeusgd
approved these changes
Aug 29, 2024
GregoryTravis
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.