Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen improvements #10876

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fullscreen improvements #10876

merged 2 commits into from
Aug 23, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Aug 22, 2024

Pull Request Description

Implements #10686.

  • Add fullscreen modes to doc editor and code editor
  • Contain fullscreen view within graph editor tab
  • Prevent persisting or synchronizing fullscreen state
  • Animate transition
Screen.Recording.2024-08-22.at.15.00.37.mov

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

- Add fullscreen modes to doc editor and code editor
- Contain fullscreen view within graph editor tab
- Prevent persisting or synchronizing fullscreen state
- Animate transition
@kazcw kazcw self-assigned this Aug 22, 2024
@kazcw kazcw marked this pull request as ready for review August 22, 2024 22:06
@kazcw kazcw linked an issue Aug 22, 2024 that may be closed by this pull request
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Aug 23, 2024
@mergify mergify bot merged commit 582b7f9 into develop Aug 23, 2024
37 checks passed
@mergify mergify bot deleted the wip/kw/fullscreen branch August 23, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Screen Mode Changes
2 participants