Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for creating Atoms in expressions #10820

Merged
merged 15 commits into from
Aug 15, 2024

Conversation

jdunkerley
Copy link
Member

Pull Request Description

  • Enables the .. autoscoping style for creating Atoms in expressions.
  • Add type checking to methods in columns.
  • Auto wrap returns from method in expressions into a column as needed.
  • Remove Time_Period.Day to remove confusion..

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley force-pushed the wip/jd/expression-improvements branch from 7172fe0 to 16cb8d6 Compare August 14, 2024 21:33
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java changes OK. Please, don't forget to add tests for the new syntax in expressions, I have not seen them in your PR yet.

Don't use sort for the test.
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Aug 15, 2024
@mergify mergify bot merged commit 422fa8c into develop Aug 15, 2024
42 checks passed
@mergify mergify bot deleted the wip/jd/expression-improvements branch August 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants