Record control tweaks #10509
Merged
Record control tweaks #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
Frizi,
vitvakatu and
kazcw
as code owners
Frizi
approved these changes
Jul 10, 2024
| @@ -29,6 +29,8 @@ import { exponentialBackoff } from 'shared/util/net' | |||
| import type { ExternalId } from 'shared/yjsModel' | |||
| import { reactive } from 'vue' | |||
|
|
|||
| const DEFAULT_ENVIRONMENT: ExecutionEnvironment = 'Design' | |||
There was a problem hiding this comment.
Is there a place where we should look to keep this synced with Java?
There was a problem hiding this comment.
I'm not aware of any "GUI-Engine common constants" place in new GUI. There was something of sort in the old GUI, but didn't feel practical.
Maybe with Bazel we design a place/library like that.
There was a problem hiding this comment.
I'm not saying that this should be automatically kept as a shared constant. Just a path to a Java file in the comment would be enough.
jdunkerley
approved these changes
Jul 10, 2024
farmaazon
requested review from
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
…/record-control-tweaks
GregoryTravis
approved these changes
Jul 10, 2024
hubertp
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10388
Screencast.from.2024-07-10.13-55-46.webm
Important Notes
Also, removed unnecessary setExecutionEnvironment call on startup
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.