Change the default location for Enso projects #10318
Conversation
4e6
added
the
CI: No changelog needed
4e6
requested review from
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
JaroslavTulach,
hubertp and
Akirathan
as code owners
| @@ -2791,6 +2792,17 @@ lazy val `benchmarks-common` = | |||
| ) | |||
| .dependsOn(`polyglot-api`) | |||
|
|
|||
| lazy val `desktop-environment` = | |||
There was a problem hiding this comment.
No 3rd party dependencies. I like such lightweight modules.
| return DirectoriesFactory.getInstance(); | ||
| } | ||
|
|
||
| public static String getOsName() { |
There was a problem hiding this comment.
If you have to define the getOsName() method at all...
lib/java/desktop-environment/src/main/java/org/enso/desktopenvironment/Platform.java
Outdated
Show resolved
Hide resolved
| import org.enso.desktopenvironment.directories.Directories; | ||
| import org.enso.desktopenvironment.directories.DirectoriesFactory; | ||
|
|
||
| public final class Platform { |
There was a problem hiding this comment.
enum Platform {
LINUX, MAC, WINDOWS
}might be better choice from an API perspective.
...-environment/src/main/java/org/enso/desktopenvironment/directories/DirectoriesException.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public Path getDocuments() throws DirectoriesException { | ||
| try { | ||
| var process = new ProcessBuilder(PROCESS_REG_QUERY).start(); |
There was a problem hiding this comment.
Avoiding a process execution would be nicer, but not even stack over flow has a suggestion how to do that nicely.
| } | ||
|
|
||
| private Path getXdgDocuments() throws IOException, InterruptedException { | ||
| var process = new ProcessBuilder(PROCESS_XDG_DOCUMENTS).start(); |
There was a problem hiding this comment.
Thanks for using xdg-user-dir I am looking forward for Enso to put the projects into the right directory on my Linux box!
|
|
||
| import java.nio.file.Path; | ||
|
|
||
| public interface Directories { |
There was a problem hiding this comment.
Do you want other code outside of this module to implement this interface? If not, then prevent it:
- (in old Java days) I'd recommend
abstract classwith package private constructor - now there is also an option to defined
sealedinterface
There was a problem hiding this comment.
Why are you deleting this file? Are the reasons for its existence obsolete?
There was a problem hiding this comment.
It was added in #4098 as a dummy Java file to be able to open the project manager in IVG.
lib/scala/project-manager/src/main/scala/org/enso/projectmanager/boot/configuration.scala
Show resolved
Hide resolved
mergify
bot
deleted the
wip/db/10240-change-the-default-location-for-enso
branch
| try { | ||
| return getXdgDocuments(); | ||
| } catch (IOException | InterruptedException e) { | ||
| return getUserHome().resolve("enso"); |
There was a problem hiding this comment.
Log a warning about a fallback?
| try { | ||
| return getUserHome().resolve(DOCUMENTS).toRealPath(); | ||
| } catch (IOException e) { | ||
| throw new IOException("Failed to resolve real MacOs documents path", e); |
There was a problem hiding this comment.
Why no fallback to whatever we have now?
|
|
||
| return Path.of(stdoutParts[4].trim()); | ||
| } catch (IOException e) { | ||
| throw new IOException("Failed to run Windows registry query", e); |
Pull Request Description
close #10240
Changelog:
desktop-environmentJava module to detect user environment configurationProjectsMigrationmodule containing the migration logic of the enso projects directorydesktopEnvironmentTS module to detect user environment configuration in theproject-manager-shimproject-manager-shimwith the new user projects directoryImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.