Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistic product #10122

Merged
merged 13 commits into from
May 31, 2024
Merged

Add statistic product #10122

merged 13 commits into from
May 31, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented May 29, 2024

Pull Request Description

Add Statistic.Product

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley force-pushed the wip/adr/add-statistic-product branch from 7188145 to 84ccb6e Compare May 29, 2024 13:47
@AdRiley AdRiley marked this pull request as ready for review May 29, 2024 13:50
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm not sure about the choice of the empty case. IMHO it makes sense to use 1 there, as then we get a property that
(a+b).compute Statistic.Product == (a.compute Statistic.Product) * (b.compute Statistic.Product), although I guess there is some rationale for 0 as a generic 'none'. But then I guess Nothing would also be valid?

@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label May 31, 2024
@mergify mergify bot merged commit 06327f8 into develop May 31, 2024
34 checks passed
@mergify mergify bot deleted the wip/adr/add-statistic-product branch May 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants