-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statistic product #10122
Add statistic product #10122
Conversation
7188145
to
84ccb6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I'm not sure about the choice of the empty case. IMHO it makes sense to use 1
there, as then we get a property that
(a+b).compute Statistic.Product == (a.compute Statistic.Product) * (b.compute Statistic.Product)
, although I guess there is some rationale for 0
as a generic 'none'. But then I guess Nothing
would also be valid?
distribution/lib/Standard/Visualization/0.0.0-dev/src/Helpers.enso
Outdated
Show resolved
Hide resolved
This reverts commit a51dc2a.
Pull Request Description
Add Statistic.Product
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.