Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "add component" menu item on component #9219

Closed
AdRiley opened this issue Feb 29, 2024 · 3 comments · Fixed by #9247
Closed

New "add component" menu item on component #9219

AdRiley opened this issue Feb 29, 2024 · 3 comments · Fixed by #9247
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 29, 2024

We want a new + menu item on the small menu that sits underneath the menu like so

image

Pressing it opens the component browser connecting a new component to the existing one.

If the visualisation is open the + button needs to move down under the visualisation

image

When the new component is added it should be positioned

  • vertically in line with where the + button is when it is pressed
  • horizontally left aligned with component it is being added from

I think the + should be grey to match the other wheel icons. Not blue like in the screenshots and the existing + button.

@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Feb 29, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 29, 2024
@farmaazon
Copy link
Contributor

When the new component is added it should be positioned

vertically in line with where the + button is when it is pressed
horizontally left aligned with component it is being added from

What if the place is already occupied? Also, I think the node appearing in place of + button will be very close to the node above - much closer than it is today, when you press enter with node selected.

@AdRiley
Copy link
Member Author

AdRiley commented Feb 29, 2024

This is the enter button spacing today

Image

Not sure we will be far out. Can always move the + button down a bit.

In terms of collisions. I think we just put it on top for first pass. The user can see where it is going to go so it is their choice.

@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels Feb 29, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 29, 2024
@kazcw kazcw self-assigned this Mar 1, 2024
@kazcw kazcw moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 1, 2024
@kazcw kazcw mentioned this issue Mar 1, 2024
5 tasks
@kazcw kazcw linked a pull request Mar 1, 2024 that will close this issue
5 tasks
@kazcw kazcw moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 1, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 1, 2024

Keziah Wesley reports a new STANDUP for today (2024-03-01):

Progress: Implemented add-node buttons. Also implemented hiding placeholders (#9208). It should be finished by 2024-03-01.

Next Day: Next day I will be working on the #9219 task. Pick something from backlog.

@mergify mergify bot closed this as completed in #9247 Mar 8, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 8, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants