Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve enso:// URIs in Data.read #9048

Closed
3 tasks done
radeusgd opened this issue Feb 13, 2024 · 3 comments · Fixed by #9225
Closed
3 tasks done

Resolve enso:// URIs in Data.read #9048

radeusgd opened this issue Feb 13, 2024 · 3 comments · Fixed by #9225
Assignees
@radeusgd
Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work p-high Should be completed in the next sprint

Comments

@radeusgd
Copy link
Member

radeusgd commented Feb 13, 2024 •
edited
Loading

We want to be able to resolve read an Enso file by an URI, e.g. Data.read "enso://radeusgd/my_dir/foo.txt".

To do so, we want to:

  • implement resolution of an enso:// path to an Enso_File instance,
    • Currently it only has to work for existing files. For a non-existing file it will return File_Error.Not_Found.
  • integrate Enso_File path resolution with the FileSystemSPI and register it for the enso:// protocol,
  • add tests for Data.read using it.
@radeusgd radeusgd added the -libs Libraries: New libraries to be implemented label Feb 13, 2024
@radeusgd radeusgd self-assigned this Feb 13, 2024
@jdunkerley jdunkerley added the p-high Should be completed in the next sprint label Feb 13, 2024
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Feb 13, 2024
@radeusgd
Copy link
Member Author

I think this has to wait until https://github.com/enso-org/cloud-v2/issues/899 is implemented.

@enso-bot enso-bot bot mentioned this issue Feb 29, 2024
Closed
7 tasks
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 29, 2024
@radeusgd radeusgd mentioned this issue Feb 29, 2024
Merged
5 tasks
@radeusgd radeusgd linked a pull request Feb 29, 2024 that will close this issue
Allow resolving enso:// URIs in Data.read and other places #9225
Merged
5 tasks
@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 29, 2024
@radeusgd radeusgd added the l-cloud-integration Enso Cloud integration work label Feb 29, 2024
@radeusgd
Copy link
Member Author

I think this has to wait until enso-org/cloud-v2#899 is implemented.

Currently implemented a workaround that resolves paths one-by-one. Later we will integrate with the backend-side resolver.

@enso-bot
Copy link

enso-bot bot commented Mar 1, 2024

Radosław Waśko reports a new STANDUP for yesterday (2024-02-29):

Progress: Prepared the datalink PR. Prepared a PR with basic enso:// path resolution. It should be finished by 2024-03-04.

Next Day: Next day I will be working on the #8590 task. Update types work to latest develop, pick up the cleanups and refactors.

@mergify mergify bot closed this as completed in #9225 Mar 2, 2024
mergify bot pushed a commit that referenced this issue Mar 2, 2024
@radeusgd
Allow resolving enso:// URIs in Data.read and other places (#9225)
39af372 
- Implements the core parts of #9048
- Currently the path resolution is done by resolving each segment, one by one - requiring as many API calls as there are segments in the path.
- This should be replaced in a followup PR, once enso-org/cloud-v2#899 is implemented.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow resolving enso:// URIs in Data.read and other places enso-org/enso
2 participants
@radeusgd @jdunkerley