Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter cmdline option to tests #8998

Closed
2 tasks done
Akirathan opened this issue Feb 7, 2024 · 8 comments · Fixed by #9065
Closed
2 tasks done

Add filter cmdline option to tests #8998

Akirathan opened this issue Feb 7, 2024 · 8 comments · Fixed by #9065
Assignees
Labels
-libs Libraries: New libraries to be implemented -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request

Comments

@Akirathan
Copy link
Member

Akirathan commented Feb 7, 2024

There is Suite.run_with_filter spec_filter group_filter method that allows to filter specs or groups. There are many main methods in tests that call into that method. Let's add an optional filter that can be passed from the cmd line. The filter will be just a single argument that will be first treated as a text and will try to match both groups and specs. If there are no matches, the filter will be interpreter as a regex.

Tasks

Preview Give feedback
@Akirathan Akirathan added -tooling Category: tooling p-high Should be completed in the next sprint x-new-feature Type: new feature request -libs Libraries: New libraries to be implemented labels Feb 7, 2024
@Akirathan Akirathan self-assigned this Feb 7, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 7, 2024
@Akirathan Akirathan moved this from ❓New to 📤 Backlog in Issues Board Feb 7, 2024
@Akirathan Akirathan moved this from 📤 Backlog to ⚙️ Design in Issues Board Feb 7, 2024
@Akirathan Akirathan moved this from ⚙️ Design to 📤 Backlog in Issues Board Feb 7, 2024
@Akirathan Akirathan added the d-easy Difficulty: little prior knowledge required label Feb 7, 2024
@Akirathan Akirathan moved this from 📤 Backlog to ⚙️ Design in Issues Board Feb 13, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 13, 2024

Pavel Marek reports a new STANDUP for today (2024-02-13):

Progress: - Engine benches work, let's see if there will be any regressions or compile problems after the dailies.

  • Bookclub
  • Managed to remove all the akka classes from runtime.jar (Remove akka from runtime #8953).
    • Fixing licenses - takes a lot of time, it is a painful process, and feels unnecessary. It should be finished by 2024-02-16.

@enso-bot
Copy link

enso-bot bot commented Feb 15, 2024

Pavel Marek reports a new STANDUP for yesterday (2024-02-14):

Progress: - Designing the new filter option to Suite.run_with_filter.

@enso-bot
Copy link

enso-bot bot commented Feb 15, 2024

Pavel Marek reports a new STANDUP for today (2024-02-15):

Progress: - filter from cmdline is ready for review #9065

  • Integrating some of the review requests. It should be finished by 2024-02-16.

@Akirathan Akirathan moved this from ⚙️ Design to 🔧 Implementation in Issues Board Feb 16, 2024
@Akirathan Akirathan moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 16, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 16, 2024

Pavel Marek reports a new STANDUP for today (2024-02-16):

Progress: - Surprisingly, Base_Tests are failing:

  • Dealing with some weird issues in Array_Proxy
  • Will have to finish this PR next week. It should be finished by 2024-02-16.

@enso-bot
Copy link

enso-bot bot commented Feb 19, 2024

Pavel Marek reports a new 🔴 DELAY for today (2024-02-19):

Summary: There is 5 days delay in implementation of the Add filter cmdline option to tests (#8998) task.
It will cause 5 days delay for the delivery of this weekly plan.

Running the tests with filter revealed some unexpected issues in the engine related to the partial evaluation in Truffle

Delay Cause: Bumped into unexpected issues with the tests

@enso-bot
Copy link

enso-bot bot commented Feb 19, 2024

Pavel Marek reports a new STANDUP for today (2024-02-19):

Progress: - Array_Proxy test fixed by fixing a GraalVM PE - related issue when checking arguments for ArrayProxy.

  • Tests in Atom_With_Hoels still remain to be fixed It should be finished by 2024-02-21.

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Pavel Marek reports a new STANDUP for today (2024-02-20):

Progress: - Created PR that ensures the correct versions of Java and GraalVM are used: #9106

  • Spent most of the time debugging a leak of cache value issue.
    • After a long struggle, created a minimal reproducer in 334c11c It should be finished by 2024-02-21.

@enso-bot
Copy link

enso-bot bot commented Feb 21, 2024

Pavel Marek reports a new STANDUP for today (2024-02-21):

Progress: - Fixed the issue with atom with hole cashing after consultation with Jaroslav.

  • Fixing another cashing related issue with EnsoHashMap that is difficult to reproduce as well
    • Discovered the issue: specialization guards are not exclusive. It should be finished by 2024-02-21.

@mergify mergify bot closed this as completed in #9065 Feb 22, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant