Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets are not shown for placeholders #8661

Closed
farmaazon opened this issue Jan 3, 2024 · 3 comments · Fixed by #8687
Closed

Widgets are not shown for placeholders #8661

farmaazon opened this issue Jan 3, 2024 · 3 comments · Fixed by #8687
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

To be done after merging #8624. This PR allows some widgets to be matched against placeholders with a specific type. But due to how our widget tree is built, those widgets are not picked - WidgetArgumentName just does not instantiate them. Drop-down works, because it has higher priority than WidgetArgumentName

@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints -gui labels Jan 3, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Jan 3, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Jan 3, 2024
@farmaazon farmaazon self-assigned this Jan 3, 2024
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 3, 2024
@enso-bot
Copy link

enso-bot bot commented Jan 4, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-01-03):

Progress: Merged remaining PRs. Investigated problem with displaying widgets on placeholders. Discussed with Paweł how to handle it properly. It should be finished by 2024-01-08.

Next Day: Next day I will be working on the same task. Do the planned refactoring.

@enso-bot
Copy link

enso-bot bot commented Jan 4, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-01-04):

Progress: Finished refactoring of widgets input and fixed some issues. It should be finished by 2024-01-08.

Next Day: Next day I will be working on the same task. Check the code for cleanup and create a PR.

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 5, 2024
@enso-bot
Copy link

enso-bot bot commented Jan 8, 2024

Adam Obuchowicz reports a new STANDUP for the last Friday (2024-01-05):

Progress: Finished code cleanup and created a PR. Started writing e2e tests for widgets. It should be finished by 2024-01-08.

Next Day: Next day I will be working on the same task. Continuing tests and planning.

@farmaazon farmaazon linked a pull request Jan 8, 2024 that will close this issue
5 tasks
@mergify mergify bot closed this as completed in #8687 Jan 8, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jan 8, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant