Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat errors from Frgaal compiler as errors, not as warnings #8513

Closed
Akirathan opened this issue Dec 11, 2023 · 2 comments · Fixed by #9834
Closed

Treat errors from Frgaal compiler as errors, not as warnings #8513

Akirathan opened this issue Dec 11, 2023 · 2 comments · Fixed by #9834
Assignees
Labels
-compiler -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-low Low priority x-chore Type: chore

Comments

@Akirathan
Copy link
Member

Errors reported from Frgaal compiler are, parsed by sbt as warnings rather than errors. For example:

[info] compiling 1 Java source to /home/pavel/dev/enso/engine/runtime/target/scala-2.13/test-classes ...
[warn] Unexpected javac output: warning: The following options were not recognized by any processor: '[truffle.dsl.SuppressWarnings]'
[warn] /home/pavel/dev/enso/engine/runtime/src/test/java/org/enso/interpreter/test/caches/ModuleCacheTest.java:50: error: serialize(EnsoContext,CachedModule) has protected access in ModuleCache
[warn]     byte[] arr = module.getCache().serialize(ensoCtx, cm);
[warn]                                   ^
[warn] /home/pavel/dev/enso/engine/runtime/src/test/java/org/enso/interpreter/test/caches/ModuleCacheTest.java:53: error: deserialize(EnsoContext,byte[],Metadata,TruffleLogger) has protected access in ModuleCache
[warn]     var cachedIr = module.getCache().deserialize(ensoCtx, arr, meta, null);
[warn]                                     ^
[warn] /home/pavel/dev/enso/engine/runtime/src/test/java/org/enso/interpreter/test/caches/ModuleCacheTest.java:76: error: serialize(EnsoContext,CachedModule) has protected access in ModuleCache
[warn]     byte[] arr = module.getCache().serialize(ensoCtx, cm);
[warn]                                   ^
[warn] /home/pavel/dev/enso/engine/runtime/src/test/java/org/enso/interpreter/test/caches/ModuleCacheTest.java:79: error: deserialize(EnsoContext,byte[],Metadata,TruffleLogger) has protected access in ModuleCache
[warn]     var cachedIr = module.getCache().deserialize(ensoCtx, arr, meta, null);
[warn]                                     ^
[warn] 4 errors
[warn] 1 warning.
[warn] frgaal exited with exit code 1
[error] (Test / compileIncremental) javac returned non-zero exit code
[error] Total time: 3 s, completed Dec 11, 2023, 7:00:16 PM

This can lead to some confusions.

Let's modify javac output processor in FrgaalCompiler.scala such that errors are correctly recognized.

@Akirathan Akirathan added d-easy Difficulty: little prior knowledge required -tooling Category: tooling x-chore Type: chore -compiler labels Dec 11, 2023
@Akirathan Akirathan self-assigned this Dec 11, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Dec 12, 2023
@Akirathan Akirathan moved this from 📤 Backlog to ❓New in Issues Board Jan 3, 2024
@Akirathan Akirathan added the p-low Low priority label Jan 3, 2024
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Jan 9, 2024
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board May 2, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board May 2, 2024
@enso-bot
Copy link

enso-bot bot commented May 3, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-02):

Progress: - fix for #8513 as #9834

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@enso-bot
Copy link

enso-bot bot commented May 4, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-03):

Progress: - WithWarnings and MetaIsATest: 7489bec

  • fixing WarningsTest: 64e1c11
  • more of WithWarnings tests & documentation
  • Rust parser changes: Error on indents #9855 It should be finished by 2024-05-03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-low Low priority x-chore Type: chore
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants