Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder nodes after connecting. #8494

Closed
Tracked by #7685
farmaazon opened this issue Dec 7, 2023 · 10 comments · Fixed by #8731
Closed
Tracked by #7685

Reorder nodes after connecting. #8494

farmaazon opened this issue Dec 7, 2023 · 10 comments · Fixed by #8731
Assignees
@Frizi
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Dec 7, 2023 •
edited
Loading

After #8367

After connecting node, we must sure that for each connection, the target node will be after the source node in the code (unless there is a cycle)
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Dec 7, 2023
@farmaazon farmaazon mentioned this issue Dec 7, 2023
Closed
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints -gui labels Dec 7, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Dec 7, 2023
@somebody1234
Copy link
Contributor

i think this would benefit from waiting for AST edits first

@vitvakatu
Copy link
Contributor

Also keep in mind that the cycle can involve arbitrary number of nodes:

a = … c …
b = … a …
c = … b …

@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 3, 2024
@Frizi Frizi mentioned this issue Jan 10, 2024
Merged
5 tasks
@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 11, 2024
@enso-bot
Copy link

enso-bot bot commented Jan 12, 2024

Paweł Grabarz reports a new STANDUP for yesterday (2024-01-11):

Progress: Added tests, fixed edits from initial empty function state and when deleting multiple nodes at once. It should be finished by 2024-01-19.

@enso-bot
Copy link

enso-bot bot commented Jan 16, 2024

Paweł Grabarz reports a new STANDUP for yesterday (2024-01-15):

Progress: Reviewed Selection Widget: shorten entries #8727 which is now merged. Working on feedback from PR for "Reorder nodes after connecting" story It should be finished by 2024-01-19.

Next Day: Next day I will be working on the #8387 task. Finish "Reorder nodes after connecting" story. After that other GUI2 defects as found. Then back to Process for simple exporting icons from Figma.

@mergify mergify bot closed this as completed in #8731 Jan 16, 2024
mergify bot pushed a commit that referenced this issue Jan 16, 2024
@Frizi
[GUI2] Implement proper connect and disconnect operation on argument …
a880fe8 
…placeholders (#8731)

- Correctly applying code edits when connecting to argument placeholders or disconnecting existing arguments.
- Prevented the placeholders from temporarily flickering right after the edit operation.
- Rewritten the placeholder argument placing logic to match the old GUI exactly - the argument should never move right after being connected.
- Fixes #8494
- Fixed some cases of ports either not existing, or existing where they shouldn't.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jan 16, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jan 18, 2024
@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2023-12-28):

Progress: Debugging AST updates, trying to understand failing widget update operations. It should be finished by 2024-01-19.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-03):

Progress: Started implementing node reordering. Started 360 Feedback. It should be finished by 2024-01-19.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-04):

Progress: Reordering blocked by incorrect AST update handling, had a meeting about AST design details. Finished 360 Feedback. It should be finished by 2024-01-19.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-09):

Progress: Continuing work on reordering after necessary AST manipulation fixes have landed. It should be finished by 2024-01-19.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-10):

Progress: Finished initial implementation and opened a PR. It should be finished by 2024-01-19.

@enso-bot
Copy link

enso-bot bot commented Jan 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-01-12):

Progress: Working on feedback from PR for "Reorder nodes after connecting" story It should be finished by 2024-01-19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frizi Frizi

Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GUI2] Implement proper connect and disconnect operation on argument placeholders enso-org/enso
4 participants
@Frizi @farmaazon @somebody1234 @vitvakatu