Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading engine widget configuration #8260

Closed
Tracked by #7685
farmaazon opened this issue Nov 8, 2023 · 8 comments · Fixed by #8400
Closed
Tracked by #7685

Reading engine widget configuration #8260

farmaazon opened this issue Nov 8, 2023 · 8 comments · Fixed by #8400
Assignees
@vitvakatu
Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Nov 8, 2023 •
edited
Loading

Finishing #8259 first could make testing it easier.

The engine configuration should be retrieved the same way as in the old GUI: attach a visualization with a specific preprocessor.
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Nov 8, 2023
@farmaazon farmaazon mentioned this issue Nov 8, 2023
Closed
@farmaazon farmaazon added d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints -gui labels Nov 8, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Nov 9, 2023
@farmaazon
Copy link
Contributor Author

Refinement notes:

  • Idea: attach the visualization in engine inside the widget - the "function call" widget should retrieve the configuration and pass it to the WidgetTree.

@vitvakatu vitvakatu moved this from 📤 Backlog to ⚙️ Design in Issues Board Nov 20, 2023
@vitvakatu vitvakatu moved this from ⚙️ Design to 🔧 Implementation in Issues Board Nov 21, 2023
@enso-bot
Copy link

enso-bot bot commented Nov 21, 2023

Ilya Bogdanov reports a new STANDUP for today (2023-11-21):

Progress: Started implementation, reviewed the old gui codebase. Implemented attaching visualization. Started implementing JSON schema for the engine update. Minor difficulties because of recursive nature of the schema and some restrictions of zod library. It should be finished by 2023-11-25.

Next Day: Next day I will be working on the same task. continue implementing schema.

@enso-bot
Copy link

enso-bot bot commented Nov 23, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-11-22):

Progress: Reading how recursive types in zod are working, implementing most of needed validation. It should be finished by 2023-11-25.

@enso-bot
Copy link

enso-bot bot commented Nov 24, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-11-23):

Progress: Playing with validation, fighting with typechecker because of recursive data structure. Also checking an issue in the old gui, wasn’t able to reproduce it. It should be finished by 2023-11-25.

@vitvakatu vitvakatu mentioned this issue Nov 27, 2023
Merged
5 tasks
@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board Nov 27, 2023
@enso-bot
Copy link

enso-bot bot commented Nov 27, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-11-24):

Progress: I understood that I could overcome typescript issues by introducing an intermediate parsing step. It solves most of the problems with the typechecker. Implementing this solution. It should be finished by 2023-11-25.

@vitvakatu vitvakatu moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 5, 2023
@enso-bot
Copy link

enso-bot bot commented Dec 5, 2023

Ilya Bogdanov reports a new 🔴 DELAY for today (2023-12-05):

Summary: There is 10 days delay in implementation of the Reading engine widget configuration (#8260) task.
It will cause 0 days delay for the delivery of this weekly plan.

6 days in total are weekends and sick leaves

Delay Cause: Mostly waiting for reviews, fixing typechecker issues.

@enso-bot
Copy link

enso-bot bot commented Dec 5, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-12-04):

Progress: Addressed review comments, merged with develop, implemented and tested attaching visualization to annotated arguments only. It should be finished by 2023-12-05.

@mergify mergify bot closed this as completed in #8400 Dec 6, 2023
mergify bot pushed a commit that referenced this issue Dec 6, 2023
@vitvakatu
Reading widget configuration from the engine (#8400)
c5a6859 
Closes #8260

<img width="846" alt="Screenshot 2023-11-27 at 5 24 57 PM" src="https://github.com/enso-org/enso/assets/6566674/da1ba325-8e9a-43e9-9e56-c672b4987e1e">

Parsed information is not used anywhere at the moment, on the screenshot you can see a temporary debug logging not included in the PR.
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Dec 12, 2023
@enso-bot
Copy link

enso-bot bot commented Dec 28, 2023

Ilya Bogdanov reports a new STANDUP for the provided date (2023-11-27):

Progress: Cleanup, opened the PR. It should be finished by 2023-12-05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reading widget configuration from the engine enso-org/enso
2 participants
@farmaazon @vitvakatu